+2007-03-19 David Smith <dsmith@redhat.com>
+
+ PR 4146 (partial fix)
+ * tapsets.cxx (all_session_groups): Added note about stating that
+ begin probes should be registered (actually run) first and end
+ probes should be unregistered (run) last.
+ * translate.cxx (c_unparser::emit_module_exit): Process probe
+ group vector in reverse order so that probe groups will get
+ unregistered in the reverse order that they were registered.
+
2007-03-19 Frank Ch. Eigler <fche@elastic.org>
* buildrun.cxx (compile_pass): Emit kbuild-time autoconf widgets
{
vector<derived_probe_group*> g;
#define DOONE(x) if (s. x##_derived_probes) g.push_back (s. x##_derived_probes)
+
+ // Note that order *is* important here. We want to make sure we
+ // register (actually run) begin probes before any other probe type
+ // is run. Similarly, when unregistering probes, we want to
+ // unregister (actually run) end probes after every other probe type
+ // has be unregistered. To do the latter,
+ // c_unparser::emit_module_exit() will run this list backwards.
DOONE(be);
DOONE(dwarf);
DOONE(timer);
// XXX: might like to have an escape hatch, in case some probe is
// genuinely stuck somehow
+ // Notice we're processing the derived_probe_group list in reverse
+ // order. This ensures that probes get unregistered in reverse
+ // order of the way they were registered.
vector<derived_probe_group*> g = all_session_groups (*session);
- for (unsigned i=0; i<g.size(); i++)
- g[i]->emit_module_exit (*session); // NB: runs "end" probes
+ for (vector<derived_probe_group*>::reverse_iterator i = g.rbegin();
+ i != g.rend(); i++)
+ (*i)->emit_module_exit (*session); // NB: runs "end" probes
for (unsigned i=0; i<session->globals.size(); i++)
{