]> sourceware.org Git - lvm2.git/commitdiff
lvconvert: fix inactive mirror up converting regression
authorHeinz Mauelshagen <heinzm@redhat.com>
Mon, 24 Apr 2017 15:44:54 +0000 (17:44 +0200)
committerHeinz Mauelshagen <heinzm@redhat.com>
Mon, 24 Apr 2017 15:44:54 +0000 (17:44 +0200)
Up converting an inactive mirror with insufficient
devs results in an over concerned warning.

Resolves: rhbz1437653

tools/lvconvert.c

index d5ca6d75da51367dc20b52bc41d5ad1c7a47d490..22967e8f3bf8aefdab2d7c3b3d5a6f7f56a7003d 100644 (file)
@@ -919,7 +919,7 @@ static int _lvconvert_mirrors_aux(struct cmd_context *cmd,
                                    MIRROR_BY_LV)) {
                        layer_lv = seg_lv(first_seg(lv), 0);
                        if (!remove_layer_from_lv(lv, layer_lv) ||
-                           !deactivate_lv(cmd, layer_lv) ||
+                           (lv_is_active(lv) && !deactivate_lv(cmd, layer_lv)) ||
                            !lv_remove(layer_lv) ||
                            !vg_write(lv->vg) || !vg_commit(lv->vg)) {
                                log_error("ABORTING: Failed to remove "
This page took 0.041215 seconds and 5 git commands to generate.