cleanup: simplify code

dm_strncpy() also check the size fits.

diff --git a/lib/locking/file_locking.c b/lib/locking/file_locking.c
index a8d041ad3c1c3e66b128b5745b9c71c46123c55e..230303b47538f5906aaa30695ad5fbdad0933cd3 100644 (file)
--- a/lib/locking/file_locking.c
+++ b/lib/locking/file_locking.c
@@ -148,13 +148,11 @@ int init_file_locking(struct locking_type *locking, struct cmd_context *cmd,
 
        /* Get lockfile directory from config file */
        locking_dir = find_config_tree_str(cmd, global_locking_dir_CFG, NULL);
-       if (strlen(locking_dir) >= sizeof(_lock_dir)) {
+       if (!dm_strncpy(_lock_dir, locking_dir, sizeof(_lock_dir))) {
                log_error("Path for locking_dir %s is invalid.", locking_dir);
                return 0;
        }
 
-       strcpy(_lock_dir, locking_dir);
-
        (void) dm_prepare_selinux_context(_lock_dir, S_IFDIR);
        r = dm_create_dir(_lock_dir);
        (void) dm_prepare_selinux_context(NULL, 0);