]> sourceware.org Git - systemtap.git/commitdiff
Don't call dwarf_lowpc after dwarf_entrypc fails
authorJosh Stone <jistone@redhat.com>
Tue, 11 Aug 2009 21:59:41 +0000 (14:59 -0700)
committerJosh Stone <jistone@redhat.com>
Wed, 12 Aug 2009 00:13:49 +0000 (17:13 -0700)
The implementation of dwarf_entrypc already checks for _lowpc, so it's
redundant for us to attempt a _lowpc call too.

* dwflpp.cxx (dwflpp::function_entrypc): Remove XXX comment.
  (dwflpp::die_entrypc): Don't bother with _lowpc if _entrypc fails

dwflpp.cxx

index d02698b2a311189102602c73688944495c113b85..c781ef7a7b3cd014b0756f091b1ed9c4449fa6ee 100644 (file)
@@ -1193,7 +1193,6 @@ dwflpp::function_entrypc (Dwarf_Addr * addr)
 {
   assert (function);
   return (dwarf_entrypc (function, addr) == 0);
-  // XXX: see also _lowpc ?
 }
 
 
@@ -1208,12 +1207,6 @@ dwflpp::die_entrypc (Dwarf_Die * die, Dwarf_Addr * addr)
   lookup_method = "dwarf_entrypc";
   rc = dwarf_entrypc (die, addr);
 
-  if (rc)
-    {
-      lookup_method = "dwarf_lowpc";
-      rc = dwarf_lowpc (die, addr);
-    }
-
   if (rc)
     {
       lookup_method = "dwarf_ranges";
This page took 0.031584 seconds and 5 git commands to generate.