coverity fixes

One pthread_create() RC check, one extra-initialized variable.

diff --git a/loc2stap.cxx b/loc2stap.cxx
index 6fd7807fe03e6ce5a8da6db81df9e7dabd8586ae..a79fcd35688eff305737a45f239cf9a142344773 100644 (file)
--- a/loc2stap.cxx
+++ b/loc2stap.cxx
@@ -796,7 +796,7 @@ location_context::frame_location()
       // the DW_AT_frame_base attribute expression's value first.
       const Dwarf_Op *fb_ops;
       Dwarf_Op *fb_expr;
-      size_t fb_len;
+      size_t fb_len = 0;
 
       if (this->fb_attr == NULL)
        {

diff --git a/stap-serverd.cxx b/stap-serverd.cxx
index 7cf76c6174b9bbc26dc25d450a8dc2d444464d35..b8f70114c8e22050ce7d542769a2874c643283aa 100644 (file)
--- a/stap-serverd.cxx
+++ b/stap-serverd.cxx
@@ -2431,10 +2431,12 @@ accept_connections (PRFileDesc *listenSocket, CERTCertificate *cert)
       t_arg->addr = addr;
 
       /* Handle the conncection */
+      int thread_rc = -1;
       if (max_threads > 0)
         /* Create the worker thread and handle the connection. */
-        pthread_create(&tid, NULL, handle_connection, t_arg);
-      else
+        thread_rc = pthread_create(&tid, NULL, handle_connection, t_arg);
+
+      if (thread_rc != 0)
         /* Since max_threads == 0, don't spawn a new thread,
          * just handle in the current thread. */
         handle_connection(t_arg);