Free text metadata buffer after a failure writing it.

diff --git a/WHATS_NEW b/WHATS_NEW
index 3b46bc9ffe086358e9a9b6cb981450b90e85de72..32e537061c535b62408084997ef743cb3bed5dde 100644 (file)
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,5 +1,6 @@
 Version 2.02.41 -
 =====================================
+  Free text metadata buffer after a failure writing it.
   Fix misleading error message when there is no allocatable extents in VG.
   Fix handling of PVs which reappeared with old metadata version.
   Fix mirror DSO to call vgreduce with proper parameters.

diff --git a/lib/format_text/format-text.c b/lib/format_text/format-text.c
index 209fb626c68a2bfca7153a738e88445d109dab7c..3e5bc4499f3d23460449ca510f09eb7758e4fee8 100644 (file)
--- a/lib/format_text/format-text.c
+++ b/lib/format_text/format-text.c
@@ -597,8 +597,15 @@ static int _vg_write_raw(struct format_instance *fid, struct volume_group *vg,
        r = 1;
 
       out:
-       if (!r && !dev_close(mdac->area.dev))
-               stack;
+       if (!r) {
+               if (!dev_close(mdac->area.dev))
+                       stack;
+
+                if (fidtc->raw_metadata_buf) {
+                        dm_free(fidtc->raw_metadata_buf);
+                        fidtc->raw_metadata_buf = NULL;
+                }
+       }
 
        return r;
 }