lvconvert: check if LV has snapshot type

Cow may not be a snapshot type, the return value of origin_from_cow(cow) may be NULL

Signed-off-by: Wu Guanghao <wuguanghao3@huawei.com>
Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>

diff --git a/tools/lvconvert.c b/tools/lvconvert.c
index d420eb52f0576e386ce54fb08badfc1d07187ac8..6ab8f6d2c717d473c9a034e6d311209cf6806834 100644 (file)
--- a/tools/lvconvert.c
+++ b/tools/lvconvert.c
@@ -1825,6 +1825,11 @@ static int _lvconvert_splitsnapshot(struct cmd_context *cmd, struct logical_volu
        struct volume_group *vg = cow->vg;
        const char *cow_name = display_lvname(cow);
 
+       if (!lv_is_snapshot(cow)) {
+               log_error(INTERNAL_ERROR "Cow volume %s is not a snapshot.", cow_name);
+               return 0;
+       }
+
        if (lv_is_virtual_origin(origin_from_cow(cow))) {
                log_error("Unable to split off snapshot %s with virtual origin.", cow_name);
                return 0;