]> sourceware.org Git - lvm2.git/commitdiff
cov: validate dev_get_primary_dev result
authorZdenek Kabelac <zkabelac@redhat.com>
Wed, 10 May 2023 11:28:38 +0000 (13:28 +0200)
committerZdenek Kabelac <zkabelac@redhat.com>
Wed, 10 May 2023 13:27:48 +0000 (15:27 +0200)
Make sure primary_dev is defined when using it.

lib/device/dev-mpath.c

index 5433b64e138c6a9ef16e507afe76f8c9872d544b..e6fc63afd8c6bd83f23a309f9a832ddebcf2f9ff 100644 (file)
@@ -688,7 +688,8 @@ int dev_is_mpath_component(struct cmd_context *cmd, struct device *dev, dev_t *h
         * primary_result 2: dev is a partition, primary_dev is the whole device
         * primary_result 1: dev is a whole device
         */
-       primary_result = dev_get_primary_dev(dt, dev, &primary_dev);
+       if (!(primary_result = dev_get_primary_dev(dt, dev, &primary_dev)))
+               return_0;
 
        if (_dev_is_mpath_component_sysfs(cmd, dev, primary_result, primary_dev, holder_devno) == 1)
                goto found;
This page took 0.031143 seconds and 5 git commands to generate.