Move va_end(ap) so we do not leave with return -1 without calling it.

Remove unneeded ';'

diff --git a/libdm/libdm-string.c b/libdm/libdm-string.c
index d8fca1a9055f04e8e80307c2c660f82cdafe59f7..365e7ec0d33f1ad024fb8210fc7f6038220a567b 100644 (file)
--- a/libdm/libdm-string.c
+++ b/libdm/libdm-string.c
@@ -144,6 +144,8 @@ int dm_asprintf(char **result, const char *format, ...)
        while (!ok) {
                va_start(ap, format);
                n = vsnprintf(buf, size, format, ap);
+               va_end(ap);
+
                if (0 <= n && n < size)
                        ok = 1;
                else {
@@ -152,8 +154,7 @@ int dm_asprintf(char **result, const char *format, ...)
                        buf = dm_malloc(size);
                        if (!buf)
                                return -1;
-               };
-               va_end(ap);
+               }
        }
 
        *result = dm_strdup(buf);