stapdyn: hide internal module functions

The header stapdyn.h is only for functions meant to be called from the
stapdyn binary into the module, so stp_dyninst_session_init_finished
shouldn't be there.  Also, all functions that aren't part of stapdyn.h
should be declared with static visibility.

diff --git a/runtime/dyninst/runtime.h b/runtime/dyninst/runtime.h
index 35dcbafe33c541e1b134bc77589f561cc7c001ea..2fc2cc79b821589351220b2483d8782ebec57d30 100644 (file)
--- a/runtime/dyninst/runtime.h
+++ b/runtime/dyninst/runtime.h
@@ -372,7 +372,7 @@ int stp_dyninst_session_init(void)
     return systemtap_module_init();
 }
 
-int stp_dyninst_session_init_finished(void)
+static int stp_dyninst_session_init_finished(void)
 {
     stp_dyninst_master = getpid();
     _stp_shm_finalize();

diff --git a/runtime/dyninst/stapdyn.h b/runtime/dyninst/stapdyn.h
index 38cda6bba0b258fc9283c36e182adfe20d09efa3..6f81df4b43d3df7842ab97146b0899491c37a9e2 100644 (file)
--- a/runtime/dyninst/stapdyn.h
+++ b/runtime/dyninst/stapdyn.h
@@ -28,7 +28,6 @@ extern "C" {
 /* STAP 2.0 : */
 
 extern int stp_dyninst_session_init(void);
-extern int stp_dyninst_session_init_finished(void);
 extern void stp_dyninst_session_exit(void);
 
 extern uint64_t stp_dyninst_target_count(void);

diff --git a/runtime/dyninst/transport.c b/runtime/dyninst/transport.c
index 7072e9d1d3aa8c4fa9a452e37d897685f59a47b5..d4905ff8908a3e36d34663b73436d2afb39f7b49 100644 (file)
--- a/runtime/dyninst/transport.c
+++ b/runtime/dyninst/transport.c
@@ -323,7 +323,7 @@ _stp_dyninst_transport_thread_func(void *arg __attribute((unused)))
        return NULL;
 }
 
-void _stp_dyninst_transport_signal_exit(void)
+static void _stp_dyninst_transport_signal_exit(void)
 {
        __stp_dyninst_transport_queue_add(STP_DYN_EXIT, 0, 0, 0);
 }