backup: show warning once per command

When command calls backup() more then once (which is actually not
wanted) this warning message is shown repeatedly:

"WARNING: This metadata update is NOT backed up."

Instead now print message just once and less confuse user.

diff --git a/WHATS_NEW b/WHATS_NEW
index e7abf591f51a1bce4d126745a7074a52a475cce9..fbaa36944e8d4e58f92d7277f5d0b35f1c72dae2 100644 (file)
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,5 +1,6 @@
 Version 2.02.169 - 
 =====================================
+  Warn about command not making metadata backup just once per command.
   Enable usage of cached volume as thin volume's external origin.
   Support cache volume activation with -real layer.
   Improve search of lock-holder for external origin and thin-pool.

diff --git a/lib/format_text/archiver.c b/lib/format_text/archiver.c
index 92799e42adb2f8240136e255f50ce6b68e25f614..d3811556d789710df632539523191ec47680a066 100644 (file)
--- a/lib/format_text/archiver.c
+++ b/lib/format_text/archiver.c
@@ -35,6 +35,7 @@ struct archive_params {
 struct backup_params {
        int enabled;
        char *dir;
+       int suppress;
 };
 
 int archive_init(struct cmd_context *cmd, const char *dir,
@@ -235,7 +236,8 @@ static int _backup(struct volume_group *vg)
 int backup_locally(struct volume_group *vg)
 {
        if (!vg->cmd->backup_params->enabled || !vg->cmd->backup_params->dir) {
-               log_warn("WARNING: This metadata update is NOT backed up");
+               log_warn_suppress(vg->cmd->backup_params->suppress++,
+                                 "WARNING: This metadata update is NOT backed up.");
                return 1;
        }