Destroy allocated mempool in _vg_read_orphans() error path.

diff --git a/WHATS_NEW b/WHATS_NEW
index 09afc08c702a29ebaff969fdcbb2dd43c5fc79ad..0b573df5abed7f1e594e5a6c58162d2d0e7db0a9 100644 (file)
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,5 +1,6 @@
 Version 2.02.57 -
 ====================================
+  Destroy allocated mempool in _vg_read_orphans() error path.
   Fix unlocking vg in some pvresize and toollib error paths.
   Explicitly call suspend for temporary mirror layer.
   Allow use precommited metadata when a PV is missing.

diff --git a/lib/metadata/metadata.c b/lib/metadata/metadata.c
index 8e3129ac9760aba9abb87e53b5c8b9f7e989d3d0..c657cd7c82186fd5f2f3421f4f058341be45e6d8 100644 (file)
--- a/lib/metadata/metadata.c
+++ b/lib/metadata/metadata.c
@@ -2380,7 +2380,7 @@ static struct volume_group *_vg_read_orphans(struct cmd_context *cmd,
 
        if (!(vg = dm_pool_zalloc(mem, sizeof(*vg)))) {
                log_error("vg allocation failed");
-               return NULL;
+               goto bad;
        }
        dm_list_init(&vg->pvs);
        dm_list_init(&vg->lvs);