If user try to vgcreate or vgextend non-existent VG,
these messages appears:
# vgcreate xxx /dev/xxx
Internal error: Volume Group xxx was not unlocked
Device /dev/xxx not found (or ignored by filtering).
Unable to add physical volume '/dev/xxx' to volume group 'xxx'.
Internal error: Attempt to unlock unlocked VG xxx.
(the same with existing VG and non-existing PV & vgextend)
# vgextend vg_test /dev/xxx
...
It is caused because code tries to "refresh" cache if
md filter is switched on using cache destroy.
But we can change filters and rescan even without this
machinery now, just use refresh_filters
(and reset md filter afterwards).
(Patch also discovers cache alias bug in vgsplit test,
fix it by using better filter line.)
Version 2.02.63 -
================================
+ Fix pvcreate device md filter check.
Suppress repeated errors about the same missing PV uuids.
Bypass full device scans when using internally-cached VG metadata.
Only do one full device scan during each read of text format metadata.
dev = dev_cache_get(name, cmd->filter);
/* Is there an md superblock here? */
+ /* FIXME: still possible issues here - rescan cache? */
if (!dev && md_filtering()) {
- unlock_vg(cmd, VG_ORPHANS);
-
- persistent_filter_wipe(cmd->filter);
- lvmcache_destroy(cmd, 1);
-
+ refresh_filters(cmd);
init_md_filtering(0);
- if (!lock_vol(cmd, VG_ORPHANS, LCK_VG_WRITE)) {
- log_error("Can't get lock for orphan PVs");
- init_md_filtering(1);
- return 0;
- }
dev = dev_cache_get(name, cmd->filter);
init_md_filtering(1);
}
. ./test-utils.sh
-prepare_lvmconf '[ "a/dev\/mirror/", "a/dev\/mapper\/.*$/", "r/.*/" ]'
+prepare_lvmconf '[ "a/dev\/mirror/", "a/dev\/mapper\/.*$/", "a/dev\/LVMTEST/", "r/.*/" ]'
aux prepare_devs 3
pvcreate $devs