]> sourceware.org Git - lvm2.git/commitdiff
bache: fix error return value
authorZdenek Kabelac <zkabelac@redhat.com>
Sat, 19 Sep 2020 21:00:50 +0000 (23:00 +0200)
committerZdenek Kabelac <zkabelac@redhat.com>
Sat, 19 Sep 2020 21:00:50 +0000 (23:00 +0200)
Return 0 as failure (as checked for).
Also add INTERNAL_ERROR if  'DI' would be -1.

lib/device/bcache.c

index c78445d9970e5970159120be9513762bff6390e7..fd18eef6ee7faa20d5be54d031747d3dedaf28e2 100644 (file)
@@ -1514,7 +1514,11 @@ void bcache_clear_fd(int di)
 int bcache_change_fd(int di, int fd)
 {
        if (di >= _fd_table_size)
-               return -1;
+               return 0;
+       if (di < 0) {
+               log_error(INTERNAL_ERROR "Cannot change not openned DI with FD:%d", fd);
+               return 0;
+       }
        _fd_table[di] = fd;
        return 1;
 }
This page took 0.039072 seconds and 5 git commands to generate.