]> sourceware.org Git - glibc.git/commitdiff
malloc: Fix transposed arguments in sysmalloc_mmap_fallback call
authorRobert Morell <rmorell@nvidia.com>
Tue, 7 Mar 2023 13:14:45 +0000 (10:14 -0300)
committerAdhemerval Zanella <adhemerval.zanella@linaro.org>
Wed, 8 Mar 2023 13:13:31 +0000 (10:13 -0300)
git commit 0849eed45daa ("malloc: Move MORECORE fallback mmap to
sysmalloc_mmap_fallback") moved a block of code from sysmalloc to a
new helper function sysmalloc_mmap_fallback(), but 'pagesize' is used
for the 'minsize' argument and 'MMAP_AS_MORECORE_SIZE' for the
'pagesize' argument.

Fixes: 0849eed45daa ("malloc: Move MORECORE fallback mmap to sysmalloc_mmap_fallback")
Signed-off-by: Robert Morell <rmorell@nvidia.com>
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
malloc/malloc.c

index 5829f3fa9b4b3690d732d727a947989c9cd4f056..76c50e3f581771d0d14552eb13b3d7bbd7d4b922 100644 (file)
@@ -2725,8 +2725,8 @@ sysmalloc (INTERNAL_SIZE_T nb, mstate av)
                                            mp_.hp_flags, av);
 #endif
          if (mbrk == MAP_FAILED)
-           mbrk = sysmalloc_mmap_fallback (&size, nb, old_size, pagesize,
-                                           MMAP_AS_MORECORE_SIZE, 0, av);
+           mbrk = sysmalloc_mmap_fallback (&size, nb, old_size, MMAP_AS_MORECORE_SIZE,
+                                           pagesize, 0, av);
          if (mbrk != MAP_FAILED)
            {
              /* We do not need, and cannot use, another sbrk call to find end */
This page took 0.047764 seconds and 5 git commands to generate.