The "should" testing utility should actually only give a warning when the

command fails.

diff --git a/test/not.c b/test/not.c
index 7456dd7c42f347b31057dba7647be496cec799e1..6b17e59160b4d467fccaf0f9657dabd66fc2aa64 100644 (file)
--- a/test/not.c
+++ b/test/not.c
@@ -8,7 +8,8 @@ int finished(const char *cmd, int status) {
        if (!strcmp(cmd, "not"))
                return !status;
        if (!strcmp(cmd, "should")) {
-               fprintf(stderr, "TEST WARNING: Ignoring command failure.\n");
+               if (status)
+                       fprintf(stderr, "TEST WARNING: Ignoring command failure.\n");
                return 0;
        }
        return 6;