]> sourceware.org Git - glibc.git/commitdiff
Polish the treatment of dl-tunable-list.h in Makeconfig.
authorZack Weinberg <zackw@panix.com>
Fri, 9 Jun 2017 13:32:43 +0000 (09:32 -0400)
committerZack Weinberg <zackw@panix.com>
Fri, 9 Jun 2017 13:35:31 +0000 (09:35 -0400)
Like basically all before-compile headers, dl-tunable-list.h should be
generated using a stamp file to minimize unnecessary rebuilding; it
wasn't being added to common-generated, so it wouldn't get cleaned up;
and it was in between the rules for libc-modules.h/.stmp and their own
addition to common-generated.

* Makeconfig (dl-tunable-list.h): Generate using a stamp file.
(common-generated): Add libc-modules.h and libc-modules.stmp in a
more appropriate location. Also add dl-tunable-list.h and
dl-tunable-list.stmp.

ChangeLog
Makeconfig

index f8f41629e366be3fcc70f4d63c965c16513dc1af..6536eb802e2cdbd6c6fdcaedae5e290ff7c36b48 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2017-06-09  Zack Weinberg  <zackw@panix.com>
+
+       * Makeconfig (dl-tunable-list.h): Generate using a stamp file.
+       (common-generated): Add libc-modules.h and libc-modules.stmp in a
+       more appropriate location. Also add dl-tunable-list.h and
+       dl-tunable-list.stmp.
+
 2017-06-09  H.J. Lu  <hongjiu.lu@intel.com>
 
        * sysdeps/x86_64/multiarch/ifunc-impl-list.c: Correct comments.
index e4eda4bcdf9f0230549235f5a064845d36dcfd68..80aed2a987bfee8ebe77feb1d9bc7105708762c3 100644 (file)
@@ -1107,6 +1107,7 @@ postclean-generated += soversions.mk soversions.i \
                       shlib-versions.v shlib-versions.v.i
 
 before-compile += $(common-objpfx)libc-modules.h
+common-generated += libc-modules.h libc-modules.stmp
 ifeq ($(soversions.mk-done),t)
 # Generate a header with macro definitions for use with the IS_IN macro.
 # These are the possible values for the MODULE_NAME macro defined when building
@@ -1125,17 +1126,19 @@ endif
 # glibc.
 ifneq (no,$(have-tunables))
 before-compile += $(common-objpfx)dl-tunable-list.h
-
-$(common-objpfx)dl-tunable-list.h: $(..)scripts/gen-tunables.awk \
-                                  $(..)elf/dl-tunables.list \
-                                  $(wildcard $(subdirs:%=$(..)%/dl-tunables.list)) \
-                                  $(wildcard $(sysdirs:%=%/dl-tunables.list))
-       $(AWK) -f $^ > $@.tmp
-       mv $@.tmp $@
+common-generated += dl-tunable-list.h dl-tunable-list.stmp
+
+$(common-objpfx)dl-tunable-list.h: $(common-objpfx)dl-tunable-list.stmp; @:
+$(common-objpfx)dl-tunable-list.stmp: \
+               $(..)scripts/gen-tunables.awk \
+               $(..)elf/dl-tunables.list \
+               $(wildcard $(subdirs:%=$(..)%/dl-tunables.list)) \
+               $(wildcard $(sysdirs:%=%/dl-tunables.list))
+       $(AWK) -f $^ > ${@:stmp=T}
+       $(move-if-change) ${@:stmp=T} ${@:stmp=h}
+       touch $@
 endif
 
-common-generated += libc-modules.h libc-modules.stmp
-
 # The name under which the run-time dynamic linker is installed.
 # We are currently going for the convention that `/lib/ld.so.1'
 # names the SVR4/ELF ABI-compliant dynamic linker.
This page took 0.161667 seconds and 5 git commands to generate.