]> sourceware.org Git - lvm2.git/commitdiff
tests: reduce amount of pvcreates
authorZdenek Kabelac <zkabelac@redhat.com>
Mon, 11 Jul 2016 13:29:28 +0000 (15:29 +0200)
committerZdenek Kabelac <zkabelac@redhat.com>
Mon, 11 Jul 2016 13:29:28 +0000 (15:29 +0200)
Reduce number of evualted pvcreate commands.
Since 0 is default value used to fill missing params,
and 0 is also 1st. value in array, it's being tested.

Drop unused data_alignment_offset.

test/api/python_lvm_unit.py

index d7152313c4c00ababb73a58c62302d23673b481f..75c370e7b989a18fec76f4240e9afb2a2602b95f 100755 (executable)
@@ -906,7 +906,6 @@ class TestLvm(unittest.TestCase):
                pvmeta_copies = [0, 1, 2]
                pvmeta_size = [0, 255, 512, 1024]
                data_alignment = [0, 2048, 4096]
-               data_alignment_offset = [1, 1, 1]
                zero = [0, 1]
 
                device_names = TestLvm._get_pv_device_names()
@@ -927,27 +926,13 @@ class TestLvm(unittest.TestCase):
 
                #Try a number of combinations and permutations
                for s in size:
-                       lvm.pvCreate(d, s)
-                       lvm.pvRemove(d)
                        for copies in pvmeta_copies:
-                               lvm.pvCreate(d, s, copies)
-                               lvm.pvRemove(d)
                                for pv_size in pvmeta_size:
-                                       lvm.pvCreate(d, s, copies, pv_size)
-                                       lvm.pvRemove(d)
                                        for align in data_alignment:
-                                               lvm.pvCreate(d, s, copies, pv_size, align)
-                                               lvm.pvRemove(d)
-                                               for align_offset in data_alignment_offset:
-                                                       lvm.pvCreate(
-                                                               d, s, copies, pv_size, align,
-                                                               align * align_offset)
+                                               for z in zero:
+                                                       lvm.pvCreate(d, s, copies, pv_size, align,
+                                                                    align, z)
                                                        lvm.pvRemove(d)
-                                                       for z in zero:
-                                                               lvm.pvCreate(
-                                                                       d, s, copies, pv_size, align,
-                                                                       align * align_offset, z)
-                                                               lvm.pvRemove(d)
 
                #Restore
                for d in device_names:
This page took 0.039022 seconds and 5 git commands to generate.