Can't use 'true' in Makefiles

diff --git a/ChangeLog b/ChangeLog
index 5ce1370592d58b11f6e7d175854e905644669fdf..d6531f5d1259d46cb03829f9bf5dead8a1c41419 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+Sun Dec 10 11:59:33 1995  Tom Tromey  <tromey@cambric.colorado.edu>
+
+       * Makefile.am (check-local): Check for 'true' in source.
+       * texinfos.am (install-info): Can't use "true" in any rule.
+
 Sat Dec  9 10:16:48 1995  Tom Tromey  <tromey@cambric.colorado.edu>
 
        * Makefile.am (cvs-dist): New target.

diff --git a/Makefile.am b/Makefile.am
index 7f23cc3d87f4e6cf6dabb88a4ba4a7a3da0cba23..aad64943a87adcd4972ce471f760d327ba90f5e8 100644 (file)
--- a/Makefile.am
+++ b/Makefile.am
@@ -26,6 +26,10 @@ ETAGS_ARGS = automake.in --lang=none \
 # The simplest form of checking.
 check-local: automake
        @PERL@ -c -w automake
+       if grep '^[^#].*true' *.am; then :; else \
+         echo "can't use 'true' in GNU Makefile" 1>&2; \
+         exit 1;                               \
+       fi
 
 automake: automake.in
        CONFIG_FILES=$@ CONFIG_HEADERS= ./config.status

diff --git a/Makefile.in b/Makefile.in
index b7356d045c51c0e9b6a9c2b6a58ebff64f90ddeb..a81f03f8fce78e3fef3155168cf37e6529f27e7c 100644 (file)
--- a/Makefile.in
+++ b/Makefile.in
@@ -293,6 +293,10 @@ maintainer-clean: distclean maintainer-clean-binSCRIPTS maintainer-clean-vti mai
 # The simplest form of checking.
 check-local: automake
        @PERL@ -c -w automake
+       if grep '^[^#].*true' *.am; then :; else \
+         echo "can't use 'true' in GNU Makefile" 1>&2; \
+         exit 1;                               \
+       fi
 
 automake: automake.in
        CONFIG_FILES=$@ CONFIG_HEADERS= ./config.status

diff --git a/lib/am/Makefile.am b/lib/am/Makefile.am
index 7f23cc3d87f4e6cf6dabb88a4ba4a7a3da0cba23..aad64943a87adcd4972ce471f760d327ba90f5e8 100644 (file)
--- a/lib/am/Makefile.am
+++ b/lib/am/Makefile.am
@@ -26,6 +26,10 @@ ETAGS_ARGS = automake.in --lang=none \
 # The simplest form of checking.
 check-local: automake
        @PERL@ -c -w automake
+       if grep '^[^#].*true' *.am; then :; else \
+         echo "can't use 'true' in GNU Makefile" 1>&2; \
+         exit 1;                               \
+       fi
 
 automake: automake.in
        CONFIG_FILES=$@ CONFIG_HEADERS= ./config.status

diff --git a/lib/am/texinfos.am b/lib/am/texinfos.am
index de68ff5c309942a55ae7c3a16e4859b31c470c04..489f6efa7a853d888cb9a0c51215698652b71782 100644 (file)
--- a/lib/am/texinfos.am
+++ b/lib/am/texinfos.am
@@ -19,12 +19,13 @@ install-info: $(INFO_DEPS)
          for ifile in $${file}*; do            \
            $(INSTALL_DATA) $$d/$$ifile $(infodir)/$$ifile; \
          done;                                 \
-## We need the 'else true' because in some broken versions of sh 'if'
-## will return false if the test fails.
+## We need the 'else' because in some broken versions of sh 'if' will
+## return false if the test fails.  We use ':' because the GNU
+## standards prohibit us from using 'true'.
 ## FIXME no one has install-info, so for now we just comment it out.
 ##       if $(SHELL) -c 'install-info --version' >/dev/null 2>&1; then \
 ##         install-info --infodir=$(infodir) $$d/$$file; \
-##       else true; fi;                        \
+##       else :; fi;                           \
        done
 
 uninstall-info:

diff --git a/texinfos.am b/texinfos.am
index de68ff5c309942a55ae7c3a16e4859b31c470c04..489f6efa7a853d888cb9a0c51215698652b71782 100644 (file)
--- a/texinfos.am
+++ b/texinfos.am
@@ -19,12 +19,13 @@ install-info: $(INFO_DEPS)
          for ifile in $${file}*; do            \
            $(INSTALL_DATA) $$d/$$ifile $(infodir)/$$ifile; \
          done;                                 \
-## We need the 'else true' because in some broken versions of sh 'if'
-## will return false if the test fails.
+## We need the 'else' because in some broken versions of sh 'if' will
+## return false if the test fails.  We use ':' because the GNU
+## standards prohibit us from using 'true'.
 ## FIXME no one has install-info, so for now we just comment it out.
 ##       if $(SHELL) -c 'install-info --version' >/dev/null 2>&1; then \
 ##         install-info --infodir=$(infodir) $$d/$$file; \
-##       else true; fi;                        \
+##       else :; fi;                           \
        done
 
 uninstall-info: