coverity: blkdeactivate: separate format and args for printf and declare and assign...

diff --git a/scripts/blkdeactivate.sh.in b/scripts/blkdeactivate.sh.in
index 39b0f2cb074bfe5a2a8aa2e55311a7cb93c69af6..2a48b3e0f2a0180878ded5a957882313bd6e2707 100644 (file)
--- a/scripts/blkdeactivate.sh.in
+++ b/scripts/blkdeactivate.sh.in
@@ -147,7 +147,7 @@ device_umount_one() {
 
        if test -z "${SKIP_UMOUNT_LIST["$mnt"]}" -a "$DO_UMOUNT" -eq "1"; then
                echo -n "  [UMOUNT]: unmounting $name ($kname) mounted on $mnt... "
-               if eval $UMOUNT $UMOUNT_OPTS "$(printf $mnt)" $OUT $ERR; then
+               if eval $UMOUNT $UMOUNT_OPTS "$(printf "%s" "$mnt")" $OUT $ERR; then
                        echo "done"
                else
                        echo "skipping"
@@ -193,7 +193,8 @@ deactivate_holders () {
 }
 
 deactivate_dm () {
-       local name=$(printf $name)
+       local name
+       name=$(printf "%s" "$name")
        test -b "$DEV_DIR/mapper/$name" || return 0
        test -z ${SKIP_DEVICE_LIST["$kname"]} || return 1
 
@@ -262,7 +263,8 @@ deactivate_lvm () {
 }
 
 deactivate_md () {
-       local name=$(printf $name)
+       local name
+       name=$(printf "%s" "$name")
        test -b "$DEV_DIR/$name" || return 0
        test -z ${SKIP_DEVICE_LIST["$kname"]} || return 1