Return EINVALID_CMD_LINE not success when invalid VG name format is used.

diff --git a/WHATS_NEW b/WHATS_NEW
index 2c168d1a10702751eb37d92b6de6d29c7a324c80..2e2ceb8331cedb9c45e77f4a137276842564f7d7 100644 (file)
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,5 +1,6 @@
 Version 2.02.50 - 
 ================================
+  Return EINVALID_CMD_LINE not success when invalid VG name format is used.
   Remove unnecessary messages after vgcreate/vgsplit refactor (2.02.49).
   Add log_errno to set a specific errno and replace log_error in due course.
   Add lvm_errno and lvm_errmsg to liblvm to obtain failure information.

diff --git a/tools/toollib.c b/tools/toollib.c
index 6f1c1a829e68d66fc48a3481d911aa28db2e7139..b50ba8e6282221b898aa0ce42591ebf83ffe5e59 100644 (file)
--- a/tools/toollib.c
+++ b/tools/toollib.c
@@ -482,6 +482,8 @@ int process_each_vg(struct cmd_context *cmd, int argc, char **argv,
                                if (!validate_name(vg_name + 1)) {
                                        log_error("Skipping invalid tag %s",
                                                  vg_name);
+                                       if (ret_max < EINVALID_CMD_LINE)
+                                               ret_max = EINVALID_CMD_LINE;
                                        continue;
                                }
                                if (!str_list_add(cmd->mem, &tags,
@@ -497,6 +499,8 @@ int process_each_vg(struct cmd_context *cmd, int argc, char **argv,
                        if (strchr(vg_name, '/')) {
                                log_error("Invalid volume group name: %s",
                                          vg_name);
+                               if (ret_max < EINVALID_CMD_LINE)
+                                       ret_max = EINVALID_CMD_LINE;
                                continue;
                        }
                        if (!str_list_add(cmd->mem, &arg_vgnames,