coverity: add some tests for function results

Even though they cannot normally happen...

diff --git a/daemons/lvmetad/lvmetad-core.c b/daemons/lvmetad/lvmetad-core.c
index 31d09335807ea04ec4b7ca55e944ddb6775ef5cf..c4c1d68a6bdcd400b89e3bc2ef1bc01c2b9066f3 100644 (file)
--- a/daemons/lvmetad/lvmetad-core.c
+++ b/daemons/lvmetad/lvmetad-core.c
@@ -861,7 +861,7 @@ static int remove_metadata(lvmetad_state *s, const char *vgid, int update_pvids)
 
        /* update_pvid_to_vgid will clear/free the pvid_to_vgid hash */
        if (update_pvids && meta_lookup)
-               _update_pvid_to_vgid(s, meta_lookup, "#orphan", 0);
+               (void) _update_pvid_to_vgid(s, meta_lookup, "#orphan", 0);
 
        /* free the unmapped data */
 

diff --git a/lib/metadata/metadata.c b/lib/metadata/metadata.c
index d8bb726279de127d6807176424f14ea9183d3db3..8a9a1b2f769d30ba2289982d427bcfbdf1a15c49 100644 (file)
--- a/lib/metadata/metadata.c
+++ b/lib/metadata/metadata.c
@@ -4641,7 +4641,8 @@ static int _check_devs_used_correspond_with_lv(struct dm_pool *mem, struct dm_li
                dev = dl->dev;
                if (!(dev->flags & DEV_ASSUMED_FOR_LV)) {
                        if (!found_inconsistent) {
-                               dm_pool_begin_object(mem, 32);
+                               if (!dm_pool_begin_object(mem, 32))
+                                       return_0;
                                found_inconsistent = 1;
                        } else {
                                if (!dm_pool_grow_object(mem, DEV_LIST_DELIM, sizeof(DEV_LIST_DELIM) - 1))
@@ -4674,7 +4675,8 @@ static int _check_devs_used_correspond_with_lv(struct dm_pool *mem, struct dm_li
                                }
                                if (!(dev->flags & DEV_USED_FOR_LV)) {
                                        if (!found_inconsistent) {
-                                               dm_pool_begin_object(mem, 32);
+                                               if (!dm_pool_begin_object(mem, 32))
+                                                        return_0;
                                                found_inconsistent = 1;
                                        } else {
                                                if (!dm_pool_grow_object(mem, DEV_LIST_DELIM, sizeof(DEV_LIST_DELIM) - 1))