.

diff --git a/WHATS_NEW b/WHATS_NEW
index 4142f81c6ad668f2df998a45bf2fd54d780e378c..57931ee0da9d98b9d7ab8a018390a640c02d79aa 100644 (file)
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,5 +1,6 @@
 Version 2.02.34 - 10th April 2008
 =================================
+  Improve preferred_names lvm.conf example.
   Fix vgdisplay 'Cur LV' field to match lvdisplay output.
   Fix lv_count report field to exclude hidden LVs.
   Add vg_is_clustered() helper function.

diff --git a/doc/example.conf b/doc/example.conf
index 25ce401ed3ed42b64cf431c127d8f1348705ebb0..8eceafe3f29686f178e0436b38f559008e485060 100644 (file)
--- a/doc/example.conf
+++ b/doc/example.conf
@@ -25,9 +25,8 @@ devices {
     # list of regular expressions in turn and the first match is used.
     preferred_names = [ ]
 
-    # If device-mapper multipath is used, more descriptive names might
-    # be preferred over the dm-N names:
-    # preferred_names = [ "^/dev/mapper/mpath" ]
+    # Try to avoid using undescriptive /dev/dm-N names, if present.
+    # preferred_names = [ "^/dev/mpath/", "^/dev/mapper/mpath", "^/dev/[hs]d" ]
 
     # A filter that tells LVM2 to only use a restricted set of devices.
     # The filter consists of an array of regular expressions.  These

diff --git a/lib/mirror/mirrored.c b/lib/mirror/mirrored.c
index f837f0b1e7c435546762b70572e5aefd3a528411..56213fb226a311404ffc6e6d31177f9e2fef3fc7 100644 (file)
--- a/lib/mirror/mirrored.c
+++ b/lib/mirror/mirrored.c
@@ -373,7 +373,7 @@ static int _mirrored_target_present(const struct lv_segment *seg __attribute((un
 
        /*
         * Check only for modules if atttributes requested and no previous check.
-        * FIXME: need better check
+        * FIXME: Fails incorrectly if cmirror was built into kernel.
         */
        if (attributes) {
                if (!_mirror_attributes && module_present("cmirror"))

diff --git a/man/lvm.conf.5 b/man/lvm.conf.5
index aa92da975e91a81468406695847adf5e81d997bc..0bb1972456271f62e13e137b2984195eeff90606 100644 (file)
--- a/man/lvm.conf.5
+++ b/man/lvm.conf.5
@@ -84,7 +84,7 @@ Defaults to "/dev".
 \fBpreferred_names\fP \(em List of patterns compared in turn against
 all the pathnames referencing the same device in in the scanned directories.
 The pathname that matches the earliest pattern in the list is the
-one used in any output.  As an example, if device mapper multipathing
+one used in any output.  As an example, if device-mapper multipathing
 is used, the following will select multipath device names:
 .br
 \fBdevices { preferred_names = [ "^/dev/mapper/mpath" ] }\fP