]> sourceware.org Git - lvm2.git/commitdiff
cleanup: do not mention segment in warning message if device not found for a PV when...
authorPeter Rajnoha <prajnoha@redhat.com>
Mon, 25 Apr 2016 09:41:36 +0000 (11:41 +0200)
committerPeter Rajnoha <prajnoha@redhat.com>
Mon, 25 Apr 2016 09:44:24 +0000 (11:44 +0200)
[0] fedora/~ # pvs --config 'devices/filter=["a|/dev/sda|", "r|.*|"]'
  WARNING: Device for PV Qcxpcy-XgtP-UD3s-PmG0-qLyE-Z0ho-DYsxoz not found or rejected by a filter.
  WARNING: Device for PV Qcxpcy-XgtP-UD3s-PmG0-qLyE-Z0ho-DYsxoz not found or rejected by a filter.
  WARNING: Couldn't find device for segment belonging to fedora/root while checking used and assumed devices.
  WARNING: Couldn't find device for segment belonging to fedora/swap while checking used and assumed devices.
  PV         VG     Fmt  Attr PSize   PFree
  /dev/sda          lvm2 ---  128.00m 128.00m
  [unknown]  fedora lvm2 a-m   19.49g      0

Probably not worth mentioning "segments" here, just state that devices
for an LV can't be all found during the check - it's less mysterious for
user then:

[0] fedora/~ # pvs --config 'devices/filter=["a|/dev/sda|", "r|.*|"]'
  WARNING: Device for PV Qcxpcy-XgtP-UD3s-PmG0-qLyE-Z0ho-DYsxoz not found or rejected by a filter.
  WARNING: Device for PV Qcxpcy-XgtP-UD3s-PmG0-qLyE-Z0ho-DYsxoz not found or rejected by a filter.
  WARNING: Couldn't find all devices for LV fedora/root while checking used and assumed devices.
  WARNING: Couldn't find all devices for LV fedora/swap while checking used and assumed devices.
  PV         VG     Fmt  Attr PSize   PFree
  /dev/sda          lvm2 ---  128.00m 128.00m
  [unknown]  fedora lvm2 a-m   19.49g      0

lib/metadata/metadata.c

index 1ceed68f7496eaaff777920707899f1031b1a322..6d101e02daa94a92843a30a5753c9e5152fb96f6 100644 (file)
@@ -4631,8 +4631,8 @@ static int _check_devs_used_correspond_with_lv(struct dm_pool *mem, struct dm_li
                        if (seg_type(seg, s) == AREA_PV) {
                                if (!(dev = seg_dev(seg, s))) {
                                        if (!warned_about_no_dev) {
-                                               log_warn("WARNING: Couldn't find device for segment belonging "
-                                                        "to %s while checking used and assumed devices.",
+                                               log_warn("WARNING: Couldn't find all devices for LV %s "
+                                                        "while checking used and assumed devices.",
                                                          display_lvname(lv));
                                                warned_about_no_dev = 1;
                                        }
This page took 0.044051 seconds and 5 git commands to generate.