Add backtraces for backup and backup_remove fail paths

diff --git a/WHATS_NEW b/WHATS_NEW
index 4fc811bc54b43775d29cb8b8aae82a7f977e1b33..96a95355fc11342ecaa6b49afdb02e81a03703ea 100644 (file)
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,5 +1,6 @@
 Version 2.02.80 - 
 ====================================
+  Add backtraces for backup and backup_remove fail paths.
   Detect errors from dm_task_set calls in _get_device_info (dmeventd).
   Add backtraces for archive and backup_locally in check_current_backup().
   Fix memory leak in debug mode of restart_clvmd() error path.

diff --git a/lib/metadata/metadata.c b/lib/metadata/metadata.c
index 5f75a66dc3d48daabde009b6931fc0e58b0a9f65..27abaea38c75ef76378d24f1bfdb93031aa275c2 100644 (file)
--- a/lib/metadata/metadata.c
+++ b/lib/metadata/metadata.c
@@ -611,7 +611,8 @@ int vg_remove(struct volume_group *vg)
                }
        }
 
-       backup_remove(vg->cmd, vg->name);
+       if (!backup_remove(vg->cmd, vg->name))
+               stack;
 
        if (ret)
                log_print("Volume group \"%s\" successfully removed", vg->name);

diff --git a/tools/vgrename.c b/tools/vgrename.c
index 98be9a960083bedba2e9671309c4ca48e296ce4f..7a4e730e205ee348e82113c39f1ed31c98714cc0 100644 (file)
--- a/tools/vgrename.c
+++ b/tools/vgrename.c
@@ -164,8 +164,10 @@ static int vg_rename_path(struct cmd_context *cmd, const char *old_vg_path,
                }
        }
 
-       backup(vg);
-       backup_remove(cmd, vg_name_old);
+       if (!backup(vg))
+               stack;
+       if (!backup_remove(cmd, vg_name_old))
+               stack;
 
        unlock_vg(cmd, vg_name_new);
        unlock_and_free_vg(cmd, vg, vg_name_old);