]> sourceware.org Git - lvm2.git/commitdiff
libdm: do not permit grouping regions with histograms
authorBryn M. Reeves <bmr@redhat.com>
Wed, 6 Jul 2016 10:10:23 +0000 (11:10 +0100)
committerBryn M. Reeves <bmr@redhat.com>
Wed, 6 Jul 2016 10:10:23 +0000 (11:10 +0100)
Although not harmful do not allow a group containing regions with
histograms since it is not currently possible to present histogram
data aggregated for the group.

libdm/libdm-stats.c

index c669b5111e0e47629aa755a9db769b3dc10bb74a..06aa64566fc1285e2be6a9f0397c6e086c0b9f3e 100644 (file)
@@ -3767,7 +3767,11 @@ int dm_stats_create_group(struct dm_stats *dms, const char *members,
                                  FMTu64, i, dms->regions[i].group_id);
                        goto bad;
                }
-
+               if (dms->regions[i].bounds) {
+                       log_error("Region ID %d: grouping regions with "
+                                 "histograms is not yet supported", i);
+                       goto bad;
+               }
                if (dms->regions[i].timescale == 1)
                        precise++;
 
This page took 0.039415 seconds and 5 git commands to generate.