Cygwin: gen_full_path_at: drop never reached code
authorCorinna Vinschen <corinna@vinschen.de>
Wed, 12 Jul 2023 11:31:31 +0000 (13:31 +0200)
committerCorinna Vinschen <corinna@vinschen.de>
Wed, 26 Jul 2023 13:19:59 +0000 (15:19 +0200)
The check if the local variable p is NULL is useless.  The preceeding
code always sets p to a valid pointer, or it crashes if path_ret is
invalid (which would be a bug in Cygwin).

Fixes: c57b57e5c43a ("* cygwin.din: Sort.")
Reviewed-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
winsup/cygwin/syscalls.cc

index 5adc614ec30fd1762a81f799694e5d5195c18850..a8b8206af0fcbb5fc165b2a434fc3674c828218a 100644 (file)
@@ -4447,11 +4447,6 @@ gen_full_path_at (char *path_ret, int dirfd, const char *pathname,
            }
          p = stpcpy (path_ret, cfd->get_name ());
        }
-      if (!p)
-       {
-         set_errno (ENOTDIR);
-         return -1;
-       }
       if (pathname)
        {
          if (!*pathname)
This page took 0.033729 seconds and 5 git commands to generate.