* cygthread.cc (cygthread::stub): Remove old, unnecessary, FIXMEd code.

* spawn.cc (child_info_spawn::worker): Avoid calling close_all_files() twice.

diff --git a/winsup/cygwin/ChangeLog b/winsup/cygwin/ChangeLog
index b35df380539a1fc00c438daf65b5efc5151e0ad1..f12459ac1847640bbd476d225159acaa7ad72e4e 100644 (file)
--- a/winsup/cygwin/ChangeLog
+++ b/winsup/cygwin/ChangeLog
@@ -1,3 +1,9 @@
+2012-09-13  Christopher Faylor  <me.cygwin2012@cgf.cx>
+
+       * cygthread.cc (cygthread::stub): Remove old, unnecessary, FIXMEd code.
+       * spawn.cc (child_info_spawn::worker): Avoid calling close_all_files()
+       twice.
+
 2012-09-02  Jin-woo Ye <jojelino@gmail.com>
            Corinna Vinschen  <corinna@vinschen.de>
 

diff --git a/winsup/cygwin/cygthread.cc b/winsup/cygwin/cygthread.cc
index 5afc42954391d220a7e00d7bd67c3f25121e8d02..2dbca06d40b7d494148ccaac486ebc83cb968ed8 100644 (file)
--- a/winsup/cygwin/cygthread.cc
+++ b/winsup/cygwin/cygthread.cc
@@ -90,12 +90,6 @@ cygthread::stub (VOID *arg)
 #endif
       else
        {
-         if (exiting)
-           {
-             info->inuse = false;      // FIXME: Do we need this?
-             return 0;
-           }
-
          info->callfunc (false);
 
          HANDLE notify = info->notify_detached;

diff --git a/winsup/cygwin/release/1.7.17 b/winsup/cygwin/release/1.7.17
index 90df145be5d94b1a633e660d8ce5d6f75f713bf3..ce2f2a0aab66f90dc16c3075d1147ccdd5ddd52f 100644 (file)
--- a/winsup/cygwin/release/1.7.17
+++ b/winsup/cygwin/release/1.7.17
@@ -24,3 +24,7 @@ Bug fixes:
 
 - Prefer to call WSARecvMsg from recvmsg if possible.
   Fixes: http://cygwin.com/ml/cygwin/2012-07/msg00662.html
+
+- Correct hang typified by running "procps" after Cygwin has started a
+  Windows process.
+  Fixes: http://cygwin.com/ml/cygwin/2012-05/threads.html#00349

diff --git a/winsup/cygwin/spawn.cc b/winsup/cygwin/spawn.cc
index 81f8bdc6ada6f30376eb4170cf6164544b12378a..5d60823b31708f169e78089411bb25a49f75244f 100644 (file)
--- a/winsup/cygwin/spawn.cc
+++ b/winsup/cygwin/spawn.cc
@@ -867,7 +867,8 @@ loop:
        }
       else
        {
-         close_all_files (true);
+         if (iscygwin ())
+           close_all_files (true);
          if (!my_wr_proc_pipe
              && WaitForSingleObject (pi.hProcess, 0) == WAIT_TIMEOUT)
            wait_for_myself ();