Differentiate between the two 'log device failed' cases in vgreduce.

diff --git a/tools/vgreduce.c b/tools/vgreduce.c
index fe8eb4c4f3172b34bcac184cf8a78eb0299df310..0c6d8f77625fa0e4b2b0fa7e19c7332921766358 100644 (file)
--- a/tools/vgreduce.c
+++ b/tools/vgreduce.c
@@ -286,13 +286,18 @@ static int _make_vg_consistent(struct cmd_context *cmd, struct volume_group *vg)
                                list_iterate_items(seg, &mirrored_seg->log_lv->segments) {
                                        /* FIXME: The second test shouldn't be required */
                                        if ((seg->segtype ==
-                                            get_segtype_from_string(vg->cmd, "error")) ||
-                                           (!strcmp(seg->segtype->name, "error"))) {
+                                            get_segtype_from_string(vg->cmd, "error"))) {
                                                log_print("The log device for %s/%s has failed.",
                                                          vg->name, mirrored_seg->lv->name);
                                                remove_log = 1;
                                                break;
                                        }
+                                       if (!strcmp(seg->segtype->name, "error")) {
+                                               log_print("Log device for %s/%s has failed.",
+                                                         vg->name, mirrored_seg->lv->name);
+                                               remove_log = 1;
+                                               break;
+                                       }
                                }
                        }