]> sourceware.org Git - lvm2.git/commitdiff
coverity: variable init must be done before its use
authorPeter Rajnoha <prajnoha@redhat.com>
Tue, 4 Aug 2015 07:51:16 +0000 (09:51 +0200)
committerPeter Rajnoha <prajnoha@redhat.com>
Tue, 4 Aug 2015 07:51:16 +0000 (09:51 +0200)
tools/polldaemon.c:465: uninit_use_in_call: Using uninitialized value "id.vg_name" when calling "print_log".
tools/polldaemon.c:465: uninit_use_in_call: Using uninitialized value "id.lv_name" when calling "print_log".

tools/polldaemon.c

index 4527efb97008be07e6b23836dea3b430e5122ec2..83928b7302dfd2d0552d6acee03b69e48ffd0456 100644 (file)
@@ -461,13 +461,14 @@ static int _lvmpolld_init_poll_vg(struct cmd_context *cmd, const char *vgname,
                if (!id.display_name && !lpdp->parms->aborting)
                        continue;
 
+               id.vg_name = lv->vg->name;
+               id.lv_name = lv->name;
+
                if (!*lv->lvid.s) {
                        log_print_unless_silent("Missing LV uuid within: %s/%s", id.vg_name, id.lv_name);
                        continue;
                }
 
-               id.vg_name = lv->vg->name;
-               id.lv_name = lv->name;
                id.uuid = lv->lvid.s;
 
                r = lvmpolld_poll_init(cmd, &id, lpdp->parms);
This page took 0.035588 seconds and 5 git commands to generate.