locking: activate_lv_excl return correct error code

Correct return code of activate_lv_excl().

Function is not supposed to return activation state of
activated volume, but return code of the operation.
Since i.e. when activation filter is allowing to activate
volume on current system, it is still success even though
no volume is activated.

diff --git a/WHATS_NEW b/WHATS_NEW
index b8a9bf7844c6ee25f965247d84aded29dd1030ea..2bf95d21eb68f4cbe08581d50e1857bd562414c4 100644 (file)
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,5 +1,6 @@
 Version 2.02.104 -
 ===================================
+  Return proper error state for remote exclusive activation.
   Fix missing lvmetad scan for PVs found on MD partitions.
   Respect DM_UDEV_DISABLE_OTHER_RULES_FLAG in lvmetad udev rules.
   Fix clvmd message verification to not reject REMOTE flag. (2.02.100)

diff --git a/lib/locking/locking.c b/lib/locking/locking.c
index 9183ee68ee6659f6cd326e0e9f2300e1bfe94219..9433e4027be3f2e253a76ae52a62a98b8f0de9b1 100644 (file)
--- a/lib/locking/locking.c
+++ b/lib/locking/locking.c
@@ -559,10 +559,10 @@ int activate_lv_excl(struct cmd_context *cmd, struct logical_volume *lv)
                return 1;
 
        /* FIXME Deal with error return codes. */
-       if (activate_lv_excl_remote(cmd, lv))
-               stack;
+       if (!activate_lv_excl_remote(cmd, lv))
+               return_0;
 
-       return lv_is_active_exclusive(lv);
+       return 1;
 }
 
 /* Lock a list of LVs */