vgchange: require confirmation with -c and no VGs

Too many people have been running 'vgchange -cy' by mistake
so add a confirmation prompt.  Use --yes to bypass this.

diff --git a/WHATS_NEW b/WHATS_NEW
index b1f379bb940759c7b1a9df6f6520b0cf8f3bb8dd..49360b2ff46015db2f6b052da2ccab9568cb5de4 100644 (file)
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,5 +1,6 @@
 Version 2.02.101 - 
 ===================================
+  Require confirmation for vgchange -c when no VGs listed explicitly.
   Also skip /var and /var/log by default in blkdeactivate when unmounting.
   Add support for bind mounts in blkdeactivate.
   Add blkdeactivate -v/--verbose for debug output from external tools used.

diff --git a/tools/vgchange.c b/tools/vgchange.c
index d41ef49a7687b19187eb6c0b0b582494f51d2464..4087fab5715c3cd571fbea24db363681fdb91b06 100644 (file)
--- a/tools/vgchange.c
+++ b/tools/vgchange.c
@@ -623,6 +623,12 @@ int vgchange(struct cmd_context *cmd, int argc, char **argv)
                return ECMD_PROCESSED;
        }
 
+       if (arg_count(cmd, clustered_ARG) && !argc && !arg_count(cmd, yes_ARG) &&
+           (yes_no_prompt("Change clustered property of all volumes groups? [y/n]: ") == 'n')) {
+               log_error("No volume groups changed.");
+               return ECMD_FAILED;
+       }
+
        if (!update || !update_partial_unsafe)
                cmd->handles_missing_pvs = 1;