Fix vgreduce --removemissing failure exit code.

diff --git a/WHATS_NEW b/WHATS_NEW
index e4e612818ce93d83b8b2683cb70b5ce0659ef75a..231939fad18412b4df62ba629ca6972e3f008b1f 100644 (file)
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,5 +1,6 @@
 Version 2.02.46 - 
 ================================
+  Fix vgreduce --removemissing failure exit code.
   Fix remote metadata backup for clvmd.
   Alloc PV internal structure from VG mempool if possible.
   Fix metadata backup to run after vg_commit always.

diff --git a/test/t-partial-activate.sh b/test/t-partial-activate.sh
index b8b1e0afc81b03890c2df5b69c96be0446d3754e..64a7967bd1ea2315d6ee7fe6f584b1918aa64cad 100644 (file)
--- a/test/t-partial-activate.sh
+++ b/test/t-partial-activate.sh
@@ -6,7 +6,6 @@ lvcreate -m 1 -l 1 -n mirror $vg
 lvchange -a n $vg/mirror
 disable_dev $dev1
 
-# FIXME should this return an error code due to that big fat WARNING?
-vgreduce --removemissing $vg
+not vgreduce --removemissing $vg
 not lvchange -v -a y $vg/mirror
 lvchange -v --partial -a y $vg/mirror

diff --git a/tools/vgreduce.c b/tools/vgreduce.c
index f8b1b07a059f8a593c25a0582379a97b141e5dee..8d407930a593406b9803b8fdd109d943efc77ef5 100644 (file)
--- a/tools/vgreduce.c
+++ b/tools/vgreduce.c
@@ -556,11 +556,13 @@ int vgreduce(struct cmd_context *cmd, int argc, char **argv)
                }
                backup(vg);
 
-               if (fixed)
+               if (fixed) {
                        log_print("Wrote out consistent volume group %s",
                                  vg_name);
+                       ret = ECMD_PROCESSED;
+               } else
+                       ret = ECMD_FAILED;
 
-               ret = ECMD_PROCESSED;
        } else {
                if (!vg_check_status(vg, EXPORTED_VG | LVM_WRITE | RESIZEABLE_VG))
                        goto out;