Add backtraces for errors

Add stack;  backtraces when error is reported from dev_set() or
dev_close_immediate().

diff --git a/WHATS_NEW b/WHATS_NEW
index 5528b0569509f64ce8f2f77c7a0e79fa72766018..c86e861341794f465fd7398de824be9d56ec1d75 100644 (file)
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,5 +1,6 @@
 Version 2.02.78 - 
 ====================================
+  Add backtraces for dev_set() and dev_close_immediate() errors in set_lv().
   Add logging for unlink() error in clvmd remove_lockfile().
   Add logging for pipe write() and close() error in clvmd child_init_signal().
   Add test for existance of orphan vginfo in _lvmcache_update_vgname().

diff --git a/lib/metadata/lv_manip.c b/lib/metadata/lv_manip.c
index 31f1ff32752318e524e2b5d7b7bb375784b5dab5..6f553cd6f8a7eecc0ab707495a6b99fc05858fce 100644 (file)
--- a/lib/metadata/lv_manip.c
+++ b/lib/metadata/lv_manip.c
@@ -3033,9 +3033,13 @@ int set_lv(struct cmd_context *cmd, struct logical_volume *lv,
        if (sectors > lv->size)
                sectors = lv->size;
 
-       dev_set(dev, UINT64_C(0), (size_t) sectors << SECTOR_SHIFT, value);
+       if (!dev_set(dev, UINT64_C(0), (size_t) sectors << SECTOR_SHIFT, value))
+               stack;
+
        dev_flush(dev);
-       dev_close_immediate(dev);
+
+       if (!dev_close_immediate(dev))
+                stack;
 
        return 1;
 }