* pipe.cc (fhandler_pipe::dup): Fix conditionals in case of error.

diff --git a/winsup/cygwin/ChangeLog b/winsup/cygwin/ChangeLog
index c222e9835fa884f3ef5e1cc8de521de151d2747b..282b8c67c8cf1d9c18490de163a7c2984c08850c 100644 (file)
--- a/winsup/cygwin/ChangeLog
+++ b/winsup/cygwin/ChangeLog
@@ -1,3 +1,7 @@
+2005-02-02  Corinna Vinschen  <corinna@vinschen.de>
+
+       * pipe.cc (fhandler_pipe::dup): Fix conditionals in case of error.
+
 2005-02-02  Corinna Vinschen  <corinna@vinschen.de>
 
        * times.cc (utimes): Mark st_ctime for update according to SUSv3.

diff --git a/winsup/cygwin/pipe.cc b/winsup/cygwin/pipe.cc
index 7dbd87a5f4a4dcd9d86fbf6a48057042324cb7cd..498b172066417fc03034f895149ca5f56e5477e2 100644 (file)
--- a/winsup/cygwin/pipe.cc
+++ b/winsup/cygwin/pipe.cc
@@ -1,6 +1,7 @@
 /* pipe.cc: pipe for Cygwin.
 
-   Copyright 1996, 1998, 1999, 2000, 2001, 2002, 2003, 2004 Red Hat, Inc.
+   Copyright 1996, 1998, 1999, 2000, 2001, 2002, 2003, 2004,
+   2005 Red Hat, Inc.
 
 This file is part of Cygwin.
 
@@ -240,11 +241,11 @@ fhandler_pipe::dup (fhandler_base *child)
   goto out;
 
 err:
-  if (!ftp->guard)
+  if (ftp->guard)
     CloseHandle (ftp->guard);
-  if (!ftp->writepipe_exists)
+  if (ftp->writepipe_exists)
     CloseHandle (ftp->writepipe_exists);
-  if (!ftp->read_state)
+  if (ftp->read_state)
     CloseHandle (ftp->read_state);
   goto leave;