]> sourceware.org Git - glibc.git/commitdiff
powerpc: Fix unrecognized instruction errors with recent GCC
authorPaul A. Clarke <pc@us.ibm.com>
Tue, 14 Sep 2021 18:13:33 +0000 (13:13 -0500)
committerPaul A. Clarke <pc@us.ibm.com>
Mon, 20 Sep 2021 21:52:38 +0000 (16:52 -0500)
Recent binutils commit b25f942e18d6ecd7ec3e2d2e9930eb4f996c258a
changes the behavior of `.machine` directives to override, rather
than augment, the base CPU. This can result in _reduced_ functionality
when, for example, compiling for default machine "power8", but explicitly
asking for ".machine power5", which loses Altivec instructions.

In tst-ucontext-ppc64-vscr.c, while the instructions provoking the new
error messages are bracketed by ".machine power5", which is ostensibly
Power ISA 2.03 (POWER5), the POWER5 processor did not support the
VSX subset, so these instructions are not recognized as "power5".

Error: unrecognized opcode: `vspltisb'
Error: unrecognized opcode: `vpkuwus'
Error: unrecognized opcode: `mfvscr'
Error: unrecognized opcode: `stvx'

Manually adding the VSX subset via ".machine altivec" is sufficient.

Reviewed-by: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
sysdeps/powerpc/powerpc64/tst-ucontext-ppc64-vscr.c

index 28c87fcef72bded6e518518f07410a91abfa18cb..d3fc4ab589f4752a71c56c790607e7ff352e9415 100644 (file)
@@ -50,6 +50,7 @@ do_test (void)
   /* Set SAT bit in VSCR register.  */
   asm volatile (".machine push;\n"
                ".machine \"power5\";\n"
+               ".machine altivec;\n"
                "vspltisb %0,0;\n"
                "vspltisb %1,-1;\n"
                "vpkuwus %0,%0,%1;\n"
This page took 0.044728 seconds and 5 git commands to generate.