]> sourceware.org Git - glibc.git/commit
S390: Derive float_t from FLT_EVAL_METHOD
authorMarius Hillenbrand <mhillen@linux.ibm.com>
Mon, 30 Nov 2020 14:53:59 +0000 (15:53 +0100)
committerStefan Liebler <stli@linux.ibm.com>
Wed, 9 Dec 2020 15:26:46 +0000 (16:26 +0100)
commitf88242af19dc970949806790f70c6fd6336944a6
tree5dbc966ce8356ff8b3f5515f151f2c7de4e61f7e
parentb5eeca8cfd9d0fd92b5633a88901d9ff27f2b496
S390: Derive float_t from FLT_EVAL_METHOD

float_t supposedly represents the type that is used to evaluate float
expressions internally. While the isa supports single-precision float
operations, the port of glibc to s390 incorrectly deferred to the
generic definitions which, back then, tied float_t to double. gcc by
default evaluates float in single precision, so that scenario violates
the C standard (sections 5.2.4.2.2 and 7.12 in C11/C17). With
-fexcess-precision=standard, gcc evaluates float in double precision,
which aligns with the standard yet at the cost of added conversion
instructions.

With this patch, we drop the s390-specific definition of float_t and
defer to the default behavior, which aligns float_t with the
compiler-defined FLT_EVAL_METHOD in a standard-compliant way.

Checked on s390x-linux-gnu with 31-bit and 64-bit builds.
NEWS
sysdeps/s390/bits/flt-eval-method.h [deleted file]
This page took 0.038555 seconds and 5 git commands to generate.