]> sourceware.org Git - glibc.git/commit
stdlib: Allow concurrent exit (BZ 31997)
authorAdhemerval Zanella <adhemerval.zanella@linaro.org>
Thu, 25 Jul 2024 18:41:44 +0000 (15:41 -0300)
committerAdhemerval Zanella <adhemerval.zanella@linaro.org>
Tue, 30 Jul 2024 11:54:23 +0000 (08:54 -0300)
commitf6ba993e0cda0ca5554fd47b00e6a87be5fdf05e
tree037d48e49be508168157ed6377136814c2a208bc
parent28f8cee64a3223636d15c78f69432503d8ef1c22
stdlib: Allow concurrent exit (BZ 31997)

Even if C/POSIX standard states that exit is not formally thread-unsafe,
calling it more than once is UB.  The glibc already supports
it for the single-thread, and both elf/nodelete2.c and tst-rseq-disable.c
call exit from a DSO destructor (which is called by _dl_fini, registered
at program startup with __cxa_atexit).

However, there are still race issues when it is called more than once
concurrently by multiple threads.  A recent Rust PR triggered this
issue [1], which resulted in an Austin Group ask for clarification [2].
Besides it, there is a discussion to make concurrent calling not UB [3],
wtih a defined semantic where any remaining callers block until the first
call to exit has finished (reentrant calls, leaving through longjmp, and
exceptions are still undefined).

For glibc, at least reentrant calls are required to be supported to avoid
changing the current behaviour.  This requires locking using a recursive
lock, where any exit called by atexit() handlers resumes at the point of
the current handler (thus avoiding calling the current handle multiple
times).

Checked on x86_64-linux-gnu and aarch64-linux-gnu.

[1] https://github.com/rust-lang/rust/issues/126600
[2] https://austingroupbugs.net/view.php?id=1845
[3] https://www.openwall.com/lists/libc-coord/2024/07/24/4
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
stdlib/Makefile
stdlib/exit.c
stdlib/tst-concurrent-exit.c [new file with mode: 0644]
This page took 0.038921 seconds and 5 git commands to generate.