]> sourceware.org Git - libabigail.git/commit
Tag add/remove/change lines unconditionally with [A], [D], [C].
authorGiuliano Procida <gprocida@google.com>
Tue, 17 Mar 2020 13:19:59 +0000 (13:19 +0000)
committerDodji Seketeli <dodji@redhat.com>
Wed, 18 Mar 2020 13:45:26 +0000 (14:45 +0100)
commitdc5e2dd893aec6251d6090430c391a9f261ce48a
treee96150bd541bf3a23d313a80d352eec17c7ab4ad
parent45c450ac6e79b91e11efb8bd5504cfe511c07b12
Tag add/remove/change lines unconditionally with [A], [D], [C].

These tags were previously only emitted by the default reporter if the
there were more than 100 (hard-coded constant) items in a a list. The
leaf reporter emitted them unconditionally. This change simplifies the
code, makes output more consistent and makes it easier to interpret
diffs of diff output.

Additionally, in the reporting of changed unreachable types, the
indentation and quoting for the deleted and added cases was missing.
This patch corrects these issues.

Finally, when doing package differences, there were no tags for
deleted/added binaries. This patch adds them.

* src/abg-default-reporter.cc (report): In the corpus_diff
override, remove calculations of number of changes (total) and
comparisons against arbitrary threshold (large_num); emit [A],
[D], [C] tags unconditionally.
* src/abg-reporter-priv.cc
(maybe_report_unreachable_type_changes): Remove comparisons of
number of changes against arbitrary threshold (large_num);
emit [A], [D], [C] tags unconditionally; fix quoting of
        deleted unreachable types; fix indentation of changed
unreachable types.
* tools/abipkgdiff.cc (compare_prepared_userspace_packages):
Emit [D] and [A] tags for removed and added binaries.
* tests/data/test-*/*report*.txt: In 109 report files, add
        tags [A], [D], [C] tags and correct some indentation and
        quoting.

Signed-off-by: Giuliano Procida <gprocida@google.com>
112 files changed:
src/abg-default-reporter.cc
src/abg-reporter-priv.cc
tests/data/test-abicompat/test1-fn-removed-report-0.txt
tests/data/test-abicompat/test2-var-removed-report-0.txt
tests/data/test-abicompat/test3-fn-removed-report-0.txt
tests/data/test-abidiff-exit/test2-filtered-removed-fns-report0.txt
tests/data/test-abidiff/test-PR18791-report0.txt
tests/data/test-diff-dwarf/PR25058-liblttng-ctl-report-1.txt
tests/data/test-diff-dwarf/test0-report.txt
tests/data/test-diff-dwarf/test16-syms-only-report.txt
tests/data/test-diff-dwarf/test17-non-refed-syms-report-0.txt
tests/data/test-diff-dwarf/test18-alias-sym-report-0.txt
tests/data/test-diff-dwarf/test19-soname-report-0.txt
tests/data/test-diff-dwarf/test28-vtable-changes-report-0.txt
tests/data/test-diff-dwarf/test29-vtable-changes-report-0.txt
tests/data/test-diff-dwarf/test30-vtable-changes-report-0.txt
tests/data/test-diff-dwarf/test31-vtable-changes-report-0.txt
tests/data/test-diff-dwarf/test32-fnptr-changes-report-0.txt
tests/data/test-diff-dwarf/test33-fnref-changes-report-0.txt
tests/data/test-diff-dwarf/test42-PR21296-clanggcc-report0.txt
tests/data/test-diff-dwarf/test7-report.txt
tests/data/test-diff-dwarf/test8-report.txt
tests/data/test-diff-dwarf/test9-report.txt
tests/data/test-diff-filter/test0-report.txt
tests/data/test-diff-filter/test01-report.txt
tests/data/test-diff-filter/test10-report.txt
tests/data/test-diff-filter/test12-report.txt
tests/data/test-diff-filter/test13-report.txt
tests/data/test-diff-filter/test2-report.txt
tests/data/test-diff-filter/test30-pr18904-rvalueref-report0.txt
tests/data/test-diff-filter/test30-pr18904-rvalueref-report1.txt
tests/data/test-diff-filter/test30-pr18904-rvalueref-report2.txt
tests/data/test-diff-filter/test31-pr18535-libstdc++-report-0.txt
tests/data/test-diff-filter/test31-pr18535-libstdc++-report-1.txt
tests/data/test-diff-filter/test35-pr18754-no-added-syms-report-0.txt
tests/data/test-diff-filter/test35-pr18754-no-added-syms-report-1.txt
tests/data/test-diff-filter/test41-report-0.txt
tests/data/test-diff-filter/test9-report.txt
tests/data/test-diff-pkg/GtkAda-gl-2.24.2-29.fc29.x86_64--2.24.2-30.fc30.x86_64-report-0.txt
tests/data/test-diff-pkg/PR24690/PR24690-report-0.txt
tests/data/test-diff-pkg/dbus-glib-0.104-3.fc23.x86_64--dbus-glib-0.104-3.fc23.armv7hl-report-0.txt
tests/data/test-diff-pkg/elfutils-libs-0.170-4.el7.x86_64-multiple-sym-vers-report-0.txt
tests/data/test-diff-pkg/libICE-1.0.6-1.el6.x86_64.rpm--libICE-1.0.9-2.el7.x86_64.rpm-report-0.txt
tests/data/test-diff-pkg/libcdio-0.94-1.fc26.x86_64--libcdio-0.94-2.fc26.x86_64-report.1.txt
tests/data/test-diff-pkg/libsigc++-2.0-0c2a_2.4.0-1_amd64--libsigc++-2.0-0v5_2.4.1-1ubuntu2_amd64-report-0.txt
tests/data/test-diff-pkg/nss-3.23.0-1.0.fc23.x86_64-report-0.txt
tests/data/test-diff-pkg/spice-server-0.12.4-19.el7.x86_64-0.12.8-1.el7.x86_64-report-0.txt
tests/data/test-diff-pkg/spice-server-0.12.4-19.el7.x86_64-0.12.8-1.el7.x86_64-report-1.txt
tests/data/test-diff-pkg/spice-server-0.12.4-19.el7.x86_64-0.12.8-1.el7.x86_64-report-2.txt
tests/data/test-diff-pkg/tbb-4.1-9.20130314.fc22.x86_64--tbb-4.3-3.20141204.fc23.x86_64-report-0.txt
tests/data/test-diff-pkg/tbb-4.1-9.20130314.fc22.x86_64--tbb-4.3-3.20141204.fc23.x86_64-report-1.txt
tests/data/test-diff-pkg/test-rpm-report-0.txt
tests/data/test-diff-pkg/test-rpm-report-1.txt
tests/data/test-diff-pkg/test-rpm-report-2.txt
tests/data/test-diff-pkg/test-rpm-report-3.txt
tests/data/test-diff-pkg/test-rpm-report-5.txt
tests/data/test-diff-suppr/test15-suppr-added-fn-report-0.txt
tests/data/test-diff-suppr/test15-suppr-added-fn-report-2.txt
tests/data/test-diff-suppr/test15-suppr-added-fn-report-5.txt
tests/data/test-diff-suppr/test16-suppr-removed-fn-report-0.txt
tests/data/test-diff-suppr/test16-suppr-removed-fn-report-3.txt
tests/data/test-diff-suppr/test16-suppr-removed-fn-report-5.txt
tests/data/test-diff-suppr/test17-suppr-added-var-report-0.txt
tests/data/test-diff-suppr/test17-suppr-added-var-report-3.txt
tests/data/test-diff-suppr/test17-suppr-added-var-report-5.txt
tests/data/test-diff-suppr/test18-suppr-removed-var-report-0.txt
tests/data/test-diff-suppr/test18-suppr-removed-var-report-3.txt
tests/data/test-diff-suppr/test18-suppr-removed-var-report-5.txt
tests/data/test-diff-suppr/test19-suppr-added-fn-sym-report-0.txt
tests/data/test-diff-suppr/test19-suppr-added-fn-sym-report-3.txt
tests/data/test-diff-suppr/test19-suppr-added-fn-sym-report-5.txt
tests/data/test-diff-suppr/test20-suppr-removed-fn-sym-report-0.txt
tests/data/test-diff-suppr/test20-suppr-removed-fn-sym-report-1.txt
tests/data/test-diff-suppr/test20-suppr-removed-fn-sym-report-2.txt
tests/data/test-diff-suppr/test20-suppr-removed-fn-sym-report-3.txt
tests/data/test-diff-suppr/test20-suppr-removed-fn-sym-report-4.txt
tests/data/test-diff-suppr/test20-suppr-removed-fn-sym-report-5.txt
tests/data/test-diff-suppr/test21-suppr-added-var-sym-report-0.txt
tests/data/test-diff-suppr/test21-suppr-added-var-sym-report-1.txt
tests/data/test-diff-suppr/test21-suppr-added-var-sym-report-2.txt
tests/data/test-diff-suppr/test21-suppr-added-var-sym-report-3.txt
tests/data/test-diff-suppr/test21-suppr-added-var-sym-report-4.txt
tests/data/test-diff-suppr/test22-suppr-removed-var-sym-report-0.txt
tests/data/test-diff-suppr/test22-suppr-removed-var-sym-report-1.txt
tests/data/test-diff-suppr/test22-suppr-removed-var-sym-report-2.txt
tests/data/test-diff-suppr/test22-suppr-removed-var-sym-report-3.txt
tests/data/test-diff-suppr/test22-suppr-removed-var-sym-report-4.txt
tests/data/test-diff-suppr/test22-suppr-removed-var-sym-report-5.txt
tests/data/test-diff-suppr/test27-add-aliased-function-report-0.txt
tests/data/test-diff-suppr/test27-add-aliased-function-report-3.txt
tests/data/test-diff-suppr/test27-add-aliased-function-report-4.txt
tests/data/test-diff-suppr/test28-add-aliased-function-report-0.txt
tests/data/test-diff-suppr/test28-add-aliased-function-report-1.txt
tests/data/test-diff-suppr/test28-add-aliased-function-report-2.txt
tests/data/test-diff-suppr/test28-add-aliased-function-report-4.txt
tests/data/test-diff-suppr/test28-add-aliased-function-report-5.txt
tests/data/test-diff-suppr/test30-report-0.txt
tests/data/test-diff-suppr/test44-suppr-sym-name-not-regexp-report-1.txt
tests/data/test-diff-suppr/test47-non-reachable-types-report-1.txt
tests/data/test-diff-suppr/test47-non-reachable-types-report-2.txt
tests/data/test-diff-suppr/test47-non-reachable-types-report-3.txt
tests/data/test-diff-suppr/test47-non-reachable-types-report-4.txt
tests/data/test-diff-suppr/test47-non-reachable-types-report-7.txt
tests/data/test-fedabipkgdiff/test0-from-fc20-to-fc23-dbus-glib-report-0.txt
tests/data/test-fedabipkgdiff/test1-from-fc20-to-dbus-glib-0.106-1.fc23.x86_64-report-0.txt
tests/data/test-fedabipkgdiff/test2-dbus-glib-0.100.2-2.fc20--dbus-glib-0.106-1.fc23-report-0.txt
tests/data/test-fedabipkgdiff/test3-dbus-glib-0.100.2-2.fc20.i686--dbus-glib-0.106-1.fc23.i686-report-0.txt
tests/data/test-fedabipkgdiff/test4-glib-0.100.2-2.fc20.x86_64.rpm-glib-0.106-1.fc23.x86_64.rpm-report-0.txt
tests/data/test-fedabipkgdiff/test5-same-dir-dbus-glib-0.100.2-2.fc20.x86_64--dbus-glib-0.106-1.fc23.x86_64-report-0.txt
tests/data/test-fedabipkgdiff/test6-nss-util-3.12.6-1.fc14.x86_64--nss-util-3.24.0-2.0.fc25.x86_64-report-0.txt
tests/data/test-fedabipkgdiff/vte291-0.39.1-1.fc22.x86_64--vte291-0.39.90-1.fc22.x86_64-report-0.txt
tools/abipkgdiff.cc
This page took 0.06648 seconds and 5 git commands to generate.