]> sourceware.org Git - glibc.git/commit
x86: Add support for building {w}memmove{_chk} with explicit ISA level
authorNoah Goldstein <goldstein.w.n@gmail.com>
Tue, 5 Jul 2022 19:41:07 +0000 (12:41 -0700)
committerNoah Goldstein <goldstein.w.n@gmail.com>
Tue, 5 Jul 2022 23:42:42 +0000 (16:42 -0700)
commitb6a02c360655cbb84772bb577fcd8ae54d7f6d82
tree578f2159fa101a04b961569ba825ca3951c47e78
parentc69f960b017b2cdf39335739009526a72fb20379
x86: Add support for building {w}memmove{_chk} with explicit ISA level

1. Refactor files so that all implementations are in the multiarch
   directory
    - Moved the implementation portion of memmove sse2 from memmove.S
      to multiarch/memmove-sse2.S

    - The non-multiarch file now only includes one of the
      implementations in the multiarch directory based on the compiled
      ISA level (only used for non-multiarch builds.  Otherwise we go
      through the ifunc selector).

2. Add ISA level build guards to different implementations.
    - I.e memmove-avx2-unaligned-erms.S which is ISA level 3 will only
      build if compiled ISA level <= 3. Otherwise there is no reason
      to include it as we will always use one of the ISA level 4
      implementations (memmove-evex-unaligned-erms.S).

3. Add new multiarch/rtld-memmove.S that just include the
   non-multiarch memmove.S which will in turn select the best
   implementation based on the compiled ISA level.

4. Refactor the ifunc selector and ifunc implementation list to use
   the ISA level aware wrapper macros that allow functions below the
   compiled ISA level (with a guranteed replacement) to be skipped.

Tested with and without multiarch on x86_64 for ISA levels:
{generic, x86-64-v2, x86-64-v3, x86-64-v4}

And m32 with and without multiarch.
isa raising memmove
sysdeps/x86_64/memmove.S
sysdeps/x86_64/multiarch/ifunc-impl-list.c
sysdeps/x86_64/multiarch/ifunc-memmove.h
sysdeps/x86_64/multiarch/memmove-avx-unaligned-erms.S
sysdeps/x86_64/multiarch/memmove-avx512-no-vzeroupper.S
sysdeps/x86_64/multiarch/memmove-avx512-unaligned-erms.S
sysdeps/x86_64/multiarch/memmove-evex-unaligned-erms.S
sysdeps/x86_64/multiarch/memmove-shlib-compat.h [new file with mode: 0644]
sysdeps/x86_64/multiarch/memmove-sse2-unaligned-erms.S
sysdeps/x86_64/multiarch/memmove-ssse3.S
sysdeps/x86_64/multiarch/rtld-memmove.S [new file with mode: 0644]
This page took 0.047441 seconds and 5 git commands to generate.