]> sourceware.org Git - newlib-cygwin.git/commit
Cygwin: drop internal O_NOSYMLINK and O_DIROPEN flags
authorCorinna Vinschen <corinna@vinschen.de>
Mon, 7 Sep 2020 20:45:38 +0000 (22:45 +0200)
committerCorinna Vinschen <corinna@vinschen.de>
Mon, 7 Sep 2020 20:45:56 +0000 (22:45 +0200)
commit8d0ff0768f6c948feb1d9383c494217f886e6b17
treeff90a7662c4a4a148c6de4e22862e231ff81f1e2
parent1f8e5847dff27e504949cd21bfeadb987d36ad19
Cygwin: drop internal O_NOSYMLINK and O_DIROPEN flags

Both flags are outdated and collide with official flags in
sys/_default_fcntl.h, which may result in weird misbehaviour
of file functions.

O_NOSYMLINK is not used anyway.

O_DIROPEN is used in fhandler_virtual and derived classes.
The collision with O_NOFOLLOW results in spurious EISDIR
errors when, e. g., reading files in the registry.
fhandler_base::open_fs uses O_DIROPEN in the call to
fhandler_base::open, but it's not used in this context
further down the road.

Drop both flags and create an alternative "diropen" bool
flag in fhandler_virtual.

Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
winsup/cygwin/fhandler.h
winsup/cygwin/fhandler_disk_file.cc
winsup/cygwin/fhandler_proc.cc
winsup/cygwin/fhandler_process.cc
winsup/cygwin/fhandler_procnet.cc
winsup/cygwin/fhandler_procsysvipc.cc
winsup/cygwin/fhandler_registry.cc
winsup/cygwin/fhandler_virtual.cc
winsup/cygwin/release/3.2.0
This page took 0.031666 seconds and 5 git commands to generate.