]> sourceware.org Git - lvm2.git/commit
Fix double releasing of vg when repairing of vg is requested.
authorMilan Broz <mbroz@redhat.com>
Fri, 5 Jun 2009 20:00:52 +0000 (20:00 +0000)
committerMilan Broz <mbroz@redhat.com>
Fri, 5 Jun 2009 20:00:52 +0000 (20:00 +0000)
commit84abdc7b2db7cda6ece58783ba759ce2f796547e
treefd6d398a3567ebd6a03af3d21de5778c6bdb7e61
parentdb79a4a14b654b32a68a62fccb47b00eba1c1380
Fix double releasing of vg when repairing of vg is requested.

Several commands calls process_each_vg() and in provided
callback it explicitly recovers VG if inconsistent.
(vgchange, vgconvert, vgscan)

It means that old VG is released and reread  but the function
above (process_one_vg) tries to unlock and release old VG.

Patch moves the repair logic into _process_one_vg() function.

It always tries to read vg (even inconsistent) and then decides
what to do according new defined parameter.

Also patch unifies inconsistent error messages.

The only slight change if for vgremove command, where
it now tries to repair VG before it removes if force arg is given.
(It works similar way before, just the order of operation changed).
16 files changed:
WHATS_NEW
lib/metadata/metadata-exported.h
test/t-inconsistent-metadata.sh
tools/polldaemon.c
tools/reporter.c
tools/toollib.c
tools/toollib.h
tools/vgcfgbackup.c
tools/vgchange.c
tools/vgck.c
tools/vgconvert.c
tools/vgdisplay.c
tools/vgexport.c
tools/vgimport.c
tools/vgremove.c
tools/vgscan.c
This page took 0.039262 seconds and 5 git commands to generate.