]> sourceware.org Git - glibc.git/commit
posix: Fix -Warray-bounds instances building timer_create [BZ #26687]
authorAdhemerval Zanella <adhemerval.zanella@linaro.org>
Mon, 5 Oct 2020 20:30:05 +0000 (17:30 -0300)
committerAdhemerval Zanella <adhemerval.zanella@linaro.org>
Tue, 6 Oct 2020 18:29:35 +0000 (15:29 -0300)
commit7a887dd537cd00fe3cdf42b788b3f0e3b430b0ed
tree2ce82095bd3f24a54af4980703cbb69cd5b7d155
parent862897d2addfacc2af85b571ebf5a82659455e8c
posix: Fix -Warray-bounds instances building timer_create [BZ #26687]

GCC 11 -Warray-bounds triggers invalid warnings when building
Linux timer_create.c:

../sysdeps/unix/sysv/linux/timer_create.c: In function '__timer_create_new':
../sysdeps/unix/sysv/linux/timer_create.c:83:17: warning: array subscript 'struct timer[0]' is partly outside array bounds of 'unsigned char[8]' [-Warray-bounds]
   83 |             newp->sigev_notify = (evp != NULL
      |                 ^~
../sysdeps/unix/sysv/linux/timer_create.c:59:47: note: referencing an object of size 8 allocated by 'malloc'
   59 |         struct timer *newp = (struct timer *) malloc (offsetof (struct timer,
      |                                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   60 |                                                                 thrfunc));
      |                                                                 ~~~~~~~~~

The struct allocated for !SIGEV_THREAD timers only requires two 'int'
fields (sigev_notify and ktimerid) and the offsetof trick tries minimize
the memory usage by only allocation the required size.  However,
although the resulting size is suffice for !SIGEV_THREAD time, accessing
the partially allocated object is error-prone and UB.

This patch fixes both issues by embedding the information whether
the timer if a SIGEV_THREAD in the returned 'timer_t'.  For
!SIGEV_THREAD, the resulting 'timer_t' is the returned kernel timer
identifer (kernel_timer_t), while for SIGEV_THREAD it uses the fact
malloc returns at least _Alignof (max_align_t) pointers plus that
valid kernel_timer_t are always positive to set MSB bit of the returned
'timer_t' to indicate the timer handles a SIGEV_THREAD.

It allows to remove the memory allocation for !SIGEV_THREAD and also
remove the 'sigev_notify' field from 'struct timer'.

Checked on x86_64-linux-gnu and i686-linux-gnu.
sysdeps/unix/sysv/linux/kernel-posix-timers.h
sysdeps/unix/sysv/linux/timer_create.c
sysdeps/unix/sysv/linux/timer_delete.c
sysdeps/unix/sysv/linux/timer_getoverr.c
sysdeps/unix/sysv/linux/timer_gettime.c
sysdeps/unix/sysv/linux/timer_settime.c
sysdeps/unix/sysv/linux/x86_64/timer_gettime.c
sysdeps/unix/sysv/linux/x86_64/timer_settime.c
This page took 0.041461 seconds and 5 git commands to generate.