]> sourceware.org Git - lvm2.git/commit
libdm: file: add proper checks for directory components in dm_create_dir
authorPeter Rajnoha <prajnoha@redhat.com>
Thu, 17 Sep 2015 12:29:51 +0000 (14:29 +0200)
committerPeter Rajnoha <prajnoha@redhat.com>
Thu, 17 Sep 2015 12:29:51 +0000 (14:29 +0200)
commit6c0b4a2769067048fa144814e298a3272564c475
tree621f9bef18a37b9ba2a0537acd2cf47a2065f19f
parentafdae26c71d2539a9f0dfb06b65541dedf28b5f5
libdm: file: add proper checks for directory components in dm_create_dir

Also make error messages more consistent:

Before this patch:

(/run/lock exists and is not a directory)
$ pvs
  /run/lock/lvm: mkdir failed: Not a directory
  File-based locking initialisation failed.

(/run/lock/lvm exists and is not a directory)
$ pvs
  Directory "/run/lock/lvm" not found
  File-based locking initialisation failed.

With this patch applied:

(/run/lock exists and is not a directory)
$ pvs
  Existing path /run/lock is not a directory.
  Failed to create directory /run/lock/lvm.
  File-based locking initialisation failed

(/run/lock/lvm exists and is not a directory)
$ pvs
  Existing path /run/lock/lvm is not a directory.
  Failed to create directory /run/lock/lvm.
  File-based locking initialisation failed.
libdm/libdm-file.c
This page took 0.03962 seconds and 5 git commands to generate.