]> sourceware.org Git - glibc.git/commit
Fix scanf rounding of negative floating-point numbers (bug 23280).
authorJoseph Myers <joseph@codesourcery.com>
Tue, 19 Jun 2018 11:52:18 +0000 (11:52 +0000)
committerJoseph Myers <joseph@codesourcery.com>
Tue, 19 Jun 2018 11:52:18 +0000 (11:52 +0000)
commit646c2833ee84aa5ecc7e219f0cc6156e61c371d3
tree1996262927420672f6acf917723309ffecfc7396
parent152fbfb3ad6387051f97248747394d6798b383ba
Fix scanf rounding of negative floating-point numbers (bug 23280).

As reported in bug 23280, scanf functions produce incorrectly rounded
result for floating-point formats in FE_UPWARD and FE_DOWNWARD modes,
because they pass the input with sign removed to strtod functions, and
then negate the result if there was a '-' at the start of the input.

This patch fixes this by arranging for the sign to be passed to strtod
rather than scanf doing the negation itself.  In turn, keeping the
sign around in the buffer being built up for strtod requires updating
places that examine char_buffer_size (&charbuf) to allow for the sign
being there as an extra character.

Tested for x86_64.

[BZ #23280]
* stdio-common/vfscanf.c (_IO_vfscanf_internal): Pass sign of
floating-point number to strtod functions rather than possibly
negating result of those functions.
* stdio-common/tst-scanf-round.c: New file.
* stdio-common/Makefile (tests): Add tst-scanf-round.
($(objpfx)tst-scanf-round): Depend on $(libm).
ChangeLog
stdio-common/Makefile
stdio-common/tst-scanf-round.c [new file with mode: 0644]
stdio-common/vfscanf.c
This page took 0.042503 seconds and 5 git commands to generate.