]> sourceware.org Git - glibc.git/commit
[BZ #22637] Fix stack guard size accounting
authorSzabolcs Nagy <szabolcs.nagy@arm.com>
Wed, 6 Dec 2017 13:05:50 +0000 (13:05 +0000)
committerSzabolcs Nagy <szabolcs.nagy@arm.com>
Mon, 8 Jan 2018 19:02:11 +0000 (19:02 +0000)
commit630f4cc3aa019ede55976ea561f1a7af2f068639
tree67f9cc70df8a9b90122106ec5be5ac7495f00dda
parentc70e4e9c9efff9df4c847dd7cfd81bae674219ab
[BZ #22637] Fix stack guard size accounting

Previously if user requested S stack and G guard when creating a
thread, the total mapping was S and the actual available stack was
S - G - static_tls, which is not what the user requested.

This patch fixes the guard size accounting by pretending the user
requested S+G stack.  This way all later logic works out except
when reporting the user requested stack size (pthread_getattr_np)
or when computing the minimal stack size (__pthread_get_minstack).

Normally this will increase thread stack allocations by one page.
TLS accounting is not affected, that will require a separate fix.

[BZ #22637]
* nptl/descr.h (stackblock, stackblock_size): Update comments.
* nptl/allocatestack.c (allocate_stack): Add guardsize to stacksize.
* nptl/nptl-init.c (__pthread_get_minstack): Remove guardsize from
stacksize.
* nptl/pthread_getattr_np.c (pthread_getattr_np): Likewise.
ChangeLog
nptl/allocatestack.c
nptl/descr.h
nptl/nptl-init.c
nptl/pthread_getattr_np.c
This page took 0.042042 seconds and 5 git commands to generate.