]> sourceware.org Git - lvm2.git/commit
activation: use revert_lv on tree suspend failure
authorZdenek Kabelac <zkabelac@redhat.com>
Tue, 22 Sep 2020 11:35:27 +0000 (13:35 +0200)
committerZdenek Kabelac <zkabelac@redhat.com>
Tue, 22 Sep 2020 19:02:14 +0000 (21:02 +0200)
commit5bc66532c70ea2e820b92eb65e0dd21f8caa3394
tree9ddc2fec7f411e0e06176ada018ec07f9de5e862
parentbc9bb534ff1bfaa8790b871a7ecd2d75bd0824f6
activation: use revert_lv on tree suspend failure

When thetable reload fails during suspend() - we were only calling
plain resume() - and this will reload only those devices,
which were left suspend, but will not try to restore
metadata state according to lvm2 reverted metadata.
So if we were reloading device tree - we have restored
only top-level LV and rest of reverted device manipulation
were left alone and possibly mismatched what is in committed
metadata.

FIXME: There are several cases were such revert will likely not work
properly anyway as some operation are currenly handled in single commit,
while they need multiple commits, but it's step towards better correctness.
At least we catch there errors now earlier.
WHATS_NEW
lib/activate/activate.c
lib/metadata/lv_manip.c
This page took 0.90773 seconds and 5 git commands to generate.