]> sourceware.org Git - libabigail.git/commit
Skip class types with changed names in leaf reports
authorDodji Seketeli <dodji@redhat.com>
Thu, 18 Jan 2018 13:20:01 +0000 (14:20 +0100)
committerDodji Seketeli <dodji@redhat.com>
Thu, 18 Jan 2018 14:56:13 +0000 (15:56 +0100)
commit4274691cdfd8ec2be02a9a3870ea23548c859b48
tree4f959f10358261cd8dcc6797afe6d405d85ec7b4
parent4a358ebfc14c13024aac882a976d53b28cdde9de
Skip class types with changed names in leaf reports

In leaf reports, a class type which is said to have changed name
should not be reported because it doesn't make sense there.  In the
full report however, a class sub-type of a type foo changed name is
worth mentioning.

This patch detects name changes of class types in the context of leaf
reports and avoid reporting impacted types.

* include/abg-comp-filter.h (has_class_or_union_type_name_change)
(has_basic_or_class_type_name_change): Declare new functions.
* include/abg-comparison.h (is_diff_of_class_or_union_type):
Likewise.
* src/abg-comp-filter.cc (has_class_or_union_type_name_change)
(has_basic_or_class_type_name_change):
* src/abg-comparison.cc
(leaf_diff_node_marker_visitor::visit_begin): Use the new
filtering::has_basic_or_class_type_name_change to test if a basic
or class/union diff type carries a name change.  Update comment.
* tests/data/test-diff-pkg/spice-server-0.12.4-19.el7.x86_64-0.12.8-1.el7.x86_64-report-3.txt:
Adjust.

Signed-off-by: Dodji Seketeli <dodji@redhat.com>
include/abg-comp-filter.h
include/abg-comparison.h
src/abg-comp-filter.cc
src/abg-comparison.cc
tests/data/test-diff-pkg/spice-server-0.12.4-19.el7.x86_64-0.12.8-1.el7.x86_64-report-3.txt
This page took 0.034511 seconds and 5 git commands to generate.