]> sourceware.org Git - libabigail.git/commit
Fix logic of function parmeters diff redundancy detection
authorDodji Seketeli <dodji@redhat.com>
Fri, 9 Jan 2015 13:11:02 +0000 (14:11 +0100)
committerDodji Seketeli <dodji@redhat.com>
Fri, 9 Jan 2015 13:11:02 +0000 (14:11 +0100)
commit3c22bdae88375feeb440a1dc86a55c19300ece22
treee52b6d9b59067ed82ebc0458ece4d86af94dd6a3
parent7c2a0940e2b3cd0373f597486e1ec5532ac62746
Fix logic of function parmeters diff redundancy detection

When looking at something else, I noticed that the code that detects
that a diff node for a function parameter was being redundant with
respect to another diff node for a parameter of the same function had
a bug; if a function parameter diff node (for a function that has more
than one parameter diff node) carried a change, then that diff node
was always considered to be redundant with another parameter diff node
of the same function.  This patch fixes that.

* src/abg-comparison.cc (redundancy_marking_visitor::visit_begin):
For a given function parameter diff node N, we were comparing it
against the other parmeter diff nodes of the function.  This
change ensures that we do not compare N against itself.

Signed-off-by: Dodji Seketeli <dodji@redhat.com>
src/abg-comparison.cc
This page took 0.035897 seconds and 5 git commands to generate.