]> sourceware.org Git - glibc.git/commit
posix: Fix posix_spawnp to not execute invalid binaries in non compat mode (BZ#23264)
authorAdhemerval Zanella <adhemerval.zanella@linaro.org>
Wed, 6 Jun 2018 17:07:34 +0000 (14:07 -0300)
committerAdhemerval Zanella <adhemerval.zanella@linaro.org>
Fri, 8 Jun 2018 20:27:46 +0000 (17:27 -0300)
commit283d98512272a12cb84e7798c23edbdf1adb287d
tree3691f644eb1109e70b48e97ac64314c9fdcedb7f
parent67c0579669ba1fc265d770252fab31babf887329
posix: Fix posix_spawnp to not execute invalid binaries in non compat mode (BZ#23264)

Current posix_spawnp implementation wrongly tries to execute invalid
binaries (for instance script without shebang) as a shell script in
non compat mode.  It was a regression introduced by
9ff72da471a509a8c19791efe469f47fa6977410 when __spawni started to use
__execvpe instead of __execve (glibc __execvpe try to execute ENOEXEC
as shell script regardless).

This patch fixes it by using an internal symbol (__execvpex) with the
faulty semantic (since compat mode is handled by spawni.c itself).

It was reported by Daniel Drake on libc-help [1].

Checked on x86_64-linux-gnu and i686-linux-gnu.

[BZ #23264]
* include/unistd.h (__execvpex): New prototype.
* posix/Makefile (tests): Add tst-spawn4.
(tests-internal): Add tst-spawn4-compat.
* posix/execvpe.c (__execvpe_common, __execvpex): New functions.
* posix/tst-spawn4-compat.c: New file.
* posix/tst-spawn4.c: Likewise.
* sysdeps/unix/sysv/linux/spawni.c (__spawni): Do not interpret invalid
binaries as shell scripts.
* sysdeps/posix/spawni.c (__spawni): Likewise.

[1] https://sourceware.org/ml/libc-help/2018-06/msg00012.html
ChangeLog
include/unistd.h
posix/Makefile
posix/execvpe.c
posix/tst-spawn4-compat.c [new file with mode: 0644]
posix/tst-spawn4.c [new file with mode: 0644]
sysdeps/posix/spawni.c
sysdeps/unix/sysv/linux/spawni.c
This page took 0.045638 seconds and 5 git commands to generate.